Support joinCommentLines setting with experimental formatter #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR only considers the tests/use cases for the joinCommentLines setting. There is a lot more missing formatting for comments that are unrelated to this setting that could be done in another PR. |
angelozerr
reviewed
Jul 19, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jul 19, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jul 19, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
Indeed let support comment formatting step by step with several p. It will easier to review it. Thats why please remove the code with formatelementcategory which is used for text node and nor for text comments node. |
JessicaJHee
force-pushed
the
joinCommentLines
branch
from
742c1db to
1652500
Compare
datho7561
requested changes
Jul 19, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/lemminx/services/format/experimental/XMLFormatterExperimentalTest.java
Show resolved
Hide resolved
JessicaJHee
force-pushed
the
joinCommentLines
branch
from
1652500 to
9b82684
Compare
datho7561
requested changes
Jul 20, 2022
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/format/DOMCommentFormatter.java
Outdated
Show resolved
Hide resolved
JessicaJHee
force-pushed
the
joinCommentLines
branch
from
9b82684 to
9209c19
Compare
angelozerr
reviewed
Jul 25, 2022
.../java/org/eclipse/lemminx/services/format/experimental/XMLFormatterJoinCommentLinesTest.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Jul 25, 2022
.../java/org/eclipse/lemminx/services/format/experimental/XMLFormatterJoinCommentLinesTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jessica He <jhe@redhat.com>
JessicaJHee
force-pushed
the
joinCommentLines
branch
from
9209c19 to
a35d8d5
Compare
|
The code looks good, @datho7561 could you please test it. If it is working, we can merge it and after that @JessicaJHee please:
|
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243
Signed-off-by: Jessica He jhe@redhat.com