Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of the first line in error messages. #1271

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Improve readability of the first line in error messages. #1271

merged 1 commit into from
Aug 15, 2022

Conversation

JessicaJHee
Copy link
Contributor

image
image

Fixes #1145

Signed-off-by: Jessica He jhe@redhat.com

@JessicaJHee
Improve readability of the first line in error messages.
0d2041b 
Signed-off-by: Jessica He <jhe@redhat.com>
@datho7561 datho7561 self-requested a review August 11, 2022 13:10
datho7561
datho7561 requested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other error messages that I think could be changed that are in the XMLSchemaMessagesReformatted.properties file:

  • cvc-complex-type.2.4.a
  • cvc-complex-type.4

@JessicaJHee
Copy link
Contributor Author

There are a few other error messages that I think could be changed that are in the XMLSchemaMessagesReformatted.properties file:

  • cvc-complex-type.2.4.a
  • cvc-complex-type.4

I believe these are already updated?
https://github.com/eclipse/lemminx/blob/0d2041b4079c9b80c1a0544b01fa91204c1d5882/org.eclipse.lemminx/src/main/resources/XMLSchemaMessagesReformatted.properties#L28

https://github.com/eclipse/lemminx/blob/0d2041b4079c9b80c1a0544b01fa91204c1d5882/org.eclipse.lemminx/src/main/resources/XMLSchemaMessagesReformatted.properties#L32

@datho7561
Copy link
Contributor

I believe these are already updated?

Yes, they were. My bad.

datho7561
datho7561 approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Jessica!

@datho7561 datho7561 merged commit 67b1340 into eclipse-lemminx:main Aug 15, 2022
@JessicaJHee JessicaJHee deleted the issue1145 branch August 15, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message to show in the first line an understandable error message
2 participants
@JessicaJHee @datho7561