-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codelens and command to register/unregister catalog #1390
Add codelens and command to register/unregister catalog #1390
Conversation
It looks promising @JessicaJHee ! I noticed that you created an custom command on client side for only XML catalog. My idea was to do like we did for vscode-microprofile, to provide a generic command which updates a given configuration on client side.
The main idea is to provide a generic command which update settings on client side. If you think it is doable, it should be nice otherwise let's give up my idea, but I think if we have more and more codeaction, codelens which need to update settings we should change that. |
fc15339
to
3903219
Compare
...x/src/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/ConfigurationItemEdit.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/ConfigurationItemEditType.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/lemminx/extensions/contentmodel/utils/ConfigurationItemValueKind.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/ConfigurationItemEditType.java
Outdated
Show resolved
Hide resolved
...x/src/main/java/org/eclipse/lemminx/extensions/contentmodel/utils/ConfigurationItemEdit.java
Outdated
Show resolved
Hide resolved
@JessicaJHee please fix conflicts |
It should be really nice to refresh coelens when To do that I suggets to add this following code after https://github.com/eclipse/lemminx/blob/de9c702be26f5380be84b3a38d6d16f6913011df/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/XMLTextDocumentService.java#L590 if (context.isRefreshCodeLenses()) {
xmlLanguageServer.getLanguageClient().refreshCodeLenses();
}
you update the refresh code lens flag
|
d05a520
to
a191899
Compare
Signed-off-by: Jessica He <jhe@redhat.com>
a191899
to
c099924
Compare
It works like a charm. Thanks @JessicaJHee ! |
Fixes redhat-developer/vscode-xml#572
Signed-off-by: Jessica He jhe@redhat.com