Suppor for textDocument/documentColor #1431
Merged
+1,274
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To play with this PR with vscode-xml, please use the PR redhat-developer/vscode-xml#849 |
fbricon
reviewed
Jan 2, 2023
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/colors/XMLColorsPlugin.java
Outdated
Show resolved
Hide resolved
|
To test this PR, write this XML color file (android) <?xml version="1.0" encoding="utf-8"?>
<resources>
<color name="opaque_red">#f00</color>
<color name="translucent_red">#80ff0000</color>
</resources>Write this settings: "xml.colors": [
{
"pattern": "**/res/values/colors.xml",
"expressions": [
{
"xpath": "resources/color/text()"
}
]
}
]You should see color:
|
|
See redhat-developer/vscode-xml#853 for declaring |
angelozerr
force-pushed
the
color
branch
3 times, most recently
from
4dd68bf to
903edec
Compare
|
please fix the commit message typo |
fixed |
JessicaJHee
suggested changes
Jan 5, 2023
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/extensions/colors/utils/ColorUtils.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLDocumentColor.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
color
branch
2 times, most recently
from
fe95db4 to
4646146
Compare
JessicaJHee
approved these changes
Jan 5, 2023
angelozerr
force-pushed
the
color
branch
3 times, most recently
from
fedfff5 to
d5608e1
Compare
Fixes eclipse-lemminx#639 Signed-off-by: azerr <azerr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppor for textDocument/documentColor
Fixes #639
Signed-off-by: azerr azerr@redhat.com