DOCTYPE tag is supported by parser #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of eclipse-lemminx#221 Doctype parsing setup. Internal DTD not complete, it instead stores as string Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
dtdParsing
branch
from
571d05f
to
d550ef1
Compare
angelozerr
reviewed
Nov 16, 2018
| * | ||
| * @param child the node child to add. | ||
| */ | ||
| public void addChild(Node child) { | ||
| public void addChildAndSetItsParent(Node child) { |
There was a problem hiding this comment.
Please don't rename this method (keep simple name, and DOM w3c works like this)
|
Very good job @NikolasKomonen ! I accept your PR, because I need it and I rename addChid again the method. It should be really cool if you could implement <!ELEMENT, <!ATTRIBUTE, <!ENTITY and their attributes in order I fix #225 |
|
@angelozerr Great!
And thats my next task. |
|
Great! See my comments at #231 (comment) |
I'm waiting for that to adjust DTD error ranges, sorry I'm so impatient :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #221
Some tests need fixing.
doctype formatting tests disabled for this pr. Will be enabled next pr on for doctype formatting.