Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for xmlns:xsi and xmlns #329

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Completion for xmlns:xsi and xmlns #329

merged 1 commit into from
Mar 20, 2019

Conversation

NikolasKomonen
Copy link
Contributor

Fixes #326, #208

@fbricon
Copy link
Contributor

fbricon commented Mar 18, 2019 •
edited
Loading

Mmmm
Screen Shot 2019-03-18 at 4 05 33 PM

that happens after adding xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" to <a>, and removing it after. all the time

@NikolasKomonen NikolasKomonen force-pushed the xsiCompletion branch 2 times, most recently from a31baeb to 02c2761 Compare March 19, 2019 16:16
@NikolasKomonen
Completion for xmlns:xsi and xmlns
b93866e 
Fixes eclipse-lemminx#326, eclipse-lemminx#208

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
@NikolasKomonen
Copy link
Contributor Author

@fbricon fixed the case of null:...

@fbricon fbricon merged commit cb0c290 into eclipse-lemminx:master Mar 20, 2019
@NikolasKomonen NikolasKomonen deleted the xsiCompletion branch April 5, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasKomonen @fbricon