Add dummy attribute when parser reaches attribute value when attr==null #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Kwon <dakwon@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679, but I'm afraid this type of bug can be very complex. This PR does not cover all cases, as I wanted to minimize the changes in DOMParser.
In the case presented in #679, the reason why the content after the quote disappears is because the parser believes that that content is part of an attribute value. But, because there is no attribute name and delimiter, the scanner reads the quote and onwards, until it finds a matching quote.
Known problems in this PR:
Quote after the question mark in the prolog:
Signed-off-by: David Kwon dakwon@redhat.com