-
Notifications
You must be signed in to change notification settings - Fork 408
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-1402:Fix Invalid datatype of Ciphersuite resource in BootstrapConfig
- Loading branch information
1 parent
fd5c9c0
commit 35e5e57
Showing
4 changed files
with
165 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
...an-server-core/src/test/java/org/eclipse/leshan/server/bootstrap/BootstrapConfigTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2016 Sierra Wireless and others. | ||
| * | ||
| * All rights reserved. This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Public License v2.0 | ||
| * and Eclipse Distribution License v1.0 which accompany this distribution. | ||
| * | ||
| * The Eclipse Public License is available at | ||
| * http://www.eclipse.org/legal/epl-v20.html | ||
| * and the Eclipse Distribution License is available at | ||
| * http://www.eclipse.org/org/documents/edl-v10.html. | ||
| * | ||
| * Contributors: | ||
| * Bartosz Stolarczyk | ||
| * Orange Polska S.A. - initial API and implementation | ||
| *******************************************************************************/ | ||
| package org.eclipse.leshan.server.bootstrap; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrowsExactly; | ||
|
|
||
| import org.eclipse.leshan.core.util.Hex; | ||
| import org.eclipse.leshan.core.util.datatype.ULong; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.CsvSource; | ||
| import org.junit.jupiter.params.provider.ValueSource; | ||
|
|
||
| class BootstrapConfigTest { | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource(value = { // given 2 bytes, expected ToString() | ||
| "C0A8 | 0xC0,0xA8", // TLS_PSK_WITH_AES_128_CCM_8 | ||
| "0003 | 0x00,0x03", // TLS_RSA_EXPORT_WITH_RC4_40_MD5 | ||
| }, delimiter = '|') | ||
| public void test_toString(String input, String expectedResult) { | ||
| // Given 2 bytes | ||
| byte[] decoded = Hex.decodeHex(input.toCharArray()); | ||
|
|
||
| // Create CipherSuiteId | ||
| BootstrapConfig.CipherSuiteId cipherSuiteId = new BootstrapConfig.CipherSuiteId(decoded[0], decoded[1]); | ||
|
|
||
| // Assert if bytes were correctly phrased | ||
| assertEquals(expectedResult, cipherSuiteId.toString()); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @CsvSource(value = { // given ulong, expected ToString() | ||
| "49320 | 0xC0,0xA8", // TLS_PSK_WITH_AES_128_CCM_8 | ||
| " 0 | 0x00,0x00", // test to lower limit | ||
| "65535 | 0xFF,0xFF", // test to upper limit | ||
|
|
||
| }, delimiter = '|') | ||
|
|
||
| public void test_create_new_CipherSuiteId_from_ULong(String input, String expectedResult) { | ||
| // Create CipherSuiteId with ULong | ||
| BootstrapConfig.CipherSuiteId cipherSuiteId = new BootstrapConfig.CipherSuiteId(ULong.valueOf(input)); | ||
|
|
||
| // Assert if ULong was correctly phrased | ||
| assertEquals(expectedResult, cipherSuiteId.toString()); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = { // | ||
| "49320", // TLS_PSK_WITH_AES_128_CCM_8 | ||
| "0", // test to lower limit | ||
| "65535", // test to upper limit | ||
| }) | ||
| public void test_getValueForSecurityObject(String input) { | ||
| // Create example ULong | ||
| ULong testValue = ULong.valueOf(input); | ||
|
|
||
| // Create cipherSuiteId from ULong | ||
| BootstrapConfig.CipherSuiteId cipherSuiteId = new BootstrapConfig.CipherSuiteId(testValue); | ||
|
|
||
| // Check if getValueForSecurityObject() returns input ULong | ||
| assertEquals(testValue, cipherSuiteId.getValueForSecurityObject()); | ||
| } | ||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = { // | ||
| "2147483647", // max 32-bit signed Integer | ||
| "2147483648", // max 32-bit signed Integer + 1 | ||
| "65536"// max 16-bit signed Integer +1 | ||
| }) | ||
| public void test_error_thrown_for_invalid_ulong(String invalidULong) { | ||
| // Create ULong from String | ||
| ULong testValue = ULong.valueOf(invalidULong); | ||
|
|
||
| // Try to create CipherSuiteId with ULong outside of range | ||
| assertThrowsExactly(IllegalArgumentException.class, () -> new BootstrapConfig.CipherSuiteId(testValue)); | ||
| } | ||
| } |