Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing keystore way to provide Ceritficate to leshan-server-demo. #1136

Closed
sbernard31 opened this issue Oct 29, 2021 · 1 comment
Closed
Labels
demo Impact our demo (not libraries) housekeeping Refactoring, cleaning code or API server Impact LWM2M server
Milestone

Comments

@sbernard31
Copy link
Contributor

Currently there is 2 way to provide certificate to leshan-server-demo :

  • KeyStore (which is currently deprecated)
  • der encoded (and not so official pem file)

For a demo I think we should limit ourself to only 1 way and so keep the der/pem encoded way :

  1. I feel that most people are more comfortable with openssl (maybe I'm wrong)
  2. I would prefer to not multiply the way to provide certificate/keys materials.
    2.1 because this means more documentation
    2.2 more code to maintain
    2.3 more use-case to test
  3. For a demo, I think we don't care to have unprotected private key. (which is one of the benefits to use KeyStore)

Just to be clear, this is just about demo, at Leshan library level, we will still be able to use KeyStore as we use java abstraction and so we don't care from where come Certificate/PublicKeyPrivateKey. So this is really just a Leshan demo question.

@sbernard31
Copy link
Contributor Author

This is remove in master with #1158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo Impact our demo (not libraries) housekeeping Refactoring, cleaning code or API server Impact LWM2M server
Projects
None yet
Development

No branches or pull requests

1 participant