Resources with no defined operations MUST NOT be considered as executable

[Warmek]

Question

Should resources with no defined operations be defined as executable in leshan server demo? For example, resource 13 in 1-1_1.xml don't have any operation defined but in leshan server demo it's displayed as executable.

[sbernard31]

Should resources with no defined operations be defined as executable in leshan server demo?

Nope, this is a bug.

[Warmek]

I want to fix it. Where should I start looking for assigning label for this button?

[sbernard31]

Just to be sure we are talking about master ? (not 1.x branch ?)

[sbernard31]

If this is about master.
I take a look at what is sent by the REST API by using my browser developer Tools.
And I see for resource 13 :

{
	"13": {
		"id": 13,
		"name": "Registration Priority Order",
		"operations": "NONE",
		"instancetype": "single",
		"mandatory": false,
		"type": "unsigned_integer",
		"range": "",
		"units": "",
		"description": "The LwM2M Client sequences the LwM2M Server registrations in increasing order of this value. If this value is not defined, registration attempts to this server are not impacted by other server registrations."
	}
}

And looking at :
https://github.com/eclipse/leshan/blob/d5052f181918af3680eb42a7428810a8fb65bcdd/leshan-server-demo/webapp/src/components/resources/ResourceControl.vue#L40-L45

and :
https://github.com/eclipse/leshan/blob/d5052f181918af3680eb42a7428810a8fb65bcdd/leshan-server-demo/webapp/src/components/resources/ResourceControl.vue#L95-L97

It seems that returning NONE or checking String contains E is not a good idea ?
I don't know what is the best move...
Maybe returning empty String instead of NONE ?
Or check that operation is strictly equals to E ? using includes make sense for R or W but not for E
See : https://github.com/eclipse/leshan/blob/d5052f181918af3680eb42a7428810a8fb65bcdd/leshan-core/src/main/java/org/eclipse/leshan/core/model/ResourceModel.java#L26-L40

[Warmek]

I've created a fix on opl/EXEButton.
I went with strictly comparing operation to "E" as I feel like switching from NONE to empty string could be confusing when debugging some issues.
To future-proof from similar issues we could change Operation "NONE" to "none" so it would be possible to have any possible combination of operations, but it seems redundant

[sbernard31]

I went with strictly comparing operation to "E" as I feel like switching from NONE to empty string could be confusing when debugging some issues.

I also feel this is the best way. 🙂

You can create a PR.

[Warmek]

I've created a PR

[sbernard31]

Fixed in master. (see #1442)

[sbernard31]

Thx @Warmek 🙏