Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement write attributes #1488

Closed
Warmek opened this issue Aug 3, 2023 · 2 comments
Closed

Implement write attributes #1488

Warmek opened this issue Aug 3, 2023 · 2 comments
Labels
question Any question about leshan

Comments

@Warmek
Copy link
Contributor

Warmek commented Aug 3, 2023

Question

I've created a PoC of how write attributes handling could be implemented for a client under branch opl/WriteAttributesClientSide
Let me know what you think of this implementation

@Warmek Warmek added the question Any question about leshan label Aug 3, 2023
@sbernard31
Copy link
Contributor

@Warmek you use several issue to talk about write attributes

Maybe we can use : #534 unless you see a good reason to not use it ?

I've created a PoC of how write attributes handling could be implemented for a client under branch opl/WriteAttributesClientSide
Let me know what you think of this implementation

I looked at your poc quickly (so maybe I missed something)
I see that ObservationTrigger is able to fire resources changes but this is not enough it should also prevent event to be raised. So it seems this is maybe not the right design or at least something is missing.
E.g. for pmin :

The Minimum Period Attribute indicates the minimum time in seconds the LwM2M Client MUST wait between two notifications. If a notification of an observed Resource is supposed to be generated but it is before pmin expiry, notification MUST be sent as soon as pmin expires. In the absence of this parameter, the Minimum Period is defined by the Default Minimum Period set in the LwM2M Server Account.

I think there is also a good question about how to handle gt and lt with californium API... 🤔

As I said before, I don't know what is the right way to implement those feature, but clearly I feel this is a not so easy and impacting feature.
Just to know, is this a really needed feature for you ? or you just try to implement it for specification support completeness.

@sbernard31
Copy link
Contributor

I guess we can close this issue, as discussion go on at #534 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Any question about leshan
Projects
None yet
Development

No branches or pull requests

2 participants