Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo bootstrap server does not enforce PSK identity uniqueness #322

Closed
scop opened this issue Apr 12, 2017 · 1 comment
Closed

Demo bootstrap server does not enforce PSK identity uniqueness #322

scop opened this issue Apr 12, 2017 · 1 comment
Labels
bsserver Impact LWM2M bootstrap server demo Impact our demo (not libraries) new feature New feature from LWM2M specification

Comments

@scop
Copy link
Contributor

scop commented Apr 12, 2017

The demo bootstrap server does not enforce PSK identity uniqueness on config add, which can lead to problems if the same PSK identity exists with different PSK secrets for a bootstrap server. The issue is basically the same as what existed for e.g. the Redis security store impl (see #320), but the fix is somewhat more laborous so I'll just report it here for now.

Note that this is primarily about PSK's in the bootstrap security configs (security->0). And as the demo BS server UI doesn't have support for setting bootstrap security configs in the first place for now, the issue can be triggered only through direct REST API access for the time being.

@sbernard31 sbernard31 added bsserver Impact LWM2M bootstrap server bug Dysfunctionnal behavior demo Impact our demo (not libraries) labels Apr 12, 2017
@sbernard31 sbernard31 added new feature New feature from LWM2M specification and removed bug Dysfunctionnal behavior labels Sep 12, 2017
@sbernard31
Copy link
Contributor

#807 should partially fix this issue as it will avoid to create 2 BootstrapConfig with the same PSK identity and the same bootstrap server.

But as our SecurityStore searches in BootstrapConfigStore to find the key corresponding to a given PSK identity nothing prevent that a bad key was reached. I mean if the BootstrapConfigStore contains 2 entries with the same PSK identity but 2 different keys for 2 different servers. SecurityStore will maybe don't find the good one.

Until we keep a SecurityStore based on BootstrapConfigStore, I can not see any good way to fix this completely. I think there is no good reason to do that in a production environment.

For a demo, I think this behavior is acceptable and waiting we rewrite this completely, we should probably live with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bsserver Impact LWM2M bootstrap server demo Impact our demo (not libraries) new feature New feature from LWM2M specification
Projects
None yet
Development

No branches or pull requests

2 participants