Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObservationServiceImpl#onNotification incorrect logging details #423

Closed
AlexITC opened this issue Nov 9, 2017 · 1 comment
Closed

ObservationServiceImpl#onNotification incorrect logging details #423

AlexITC opened this issue Nov 9, 2017 · 1 comment
Labels
bug Dysfunctionnal behavior server Impact LWM2M server

Comments

@AlexITC
Copy link
Contributor

AlexITC commented Nov 9, 2017

The onNotification method is logging wrong details when the observation is not found for the request.

The current log has the observation instead of the token, and the token instead of the registration:

        // get observation for this request
        Observation observation = registrationStore.getObservation(regid, coapResponse.getToken());
        if (observation == null) {
            LOG.error("Unexpected error: Unable to find observation with token {} for registration {}", observation,
                    coapResponse.getToken());
            return;
}
sbernard31 pushed a commit that referenced this issue Nov 9, 2017
Signed-off-by: Alexis Hernandez <alexis22229@gmail.com>
@sbernard31 sbernard31 added bug Dysfunctionnal behavior server Impact LWM2M server labels Nov 9, 2017
@sbernard31
Copy link
Contributor

Good catch ! Thx !
Fixed by #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dysfunctionnal behavior server Impact LWM2M server
Projects
None yet
Development

No branches or pull requests

2 participants