Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise CodecExpection if 2 node has the same Id for the same parent #429

Closed
sbernard31 opened this issue Nov 9, 2017 · 1 comment
Closed

Raise CodecExpection if 2 node has the same Id for the same parent #429

sbernard31 opened this issue Nov 9, 2017 · 1 comment
Labels
bsserver Impact LWM2M bootstrap server client Impact LWM2M client new feature New feature from LWM2M specification server Impact LWM2M server

Comments

@sbernard31
Copy link
Contributor

a TLV (or JSON) payload could contain identifier conflict : 2 (or more) nodes with the same id for the same parent.
It that case Leshan just keep the last one and throw out the others silently.
We should raise a CodecException instead.

This issue was fixed for TLV at resource instance level : #426.
But we should check resource and instance level for TLV (and maybe JSON...)
@sbernard31 sbernard31 added bsserver Impact LWM2M bootstrap server client Impact LWM2M client new feature New feature from LWM2M specification server Impact LWM2M server labels Nov 9, 2017
sbernard31 added a commit that referenced this issue May 30, 2018
@sbernard31
#429 : add tests for tlv about 2 node with same Id
cdb32d8
sbernard31 added a commit that referenced this issue May 30, 2018
@sbernard31
#429 : Raise CodecExpection if 2 node with same Id in TLV decoder
16d3c2d
sbernard31 added a commit that referenced this issue May 30, 2018
@sbernard31
#429 : add tests for json about 2 node with same Id
0ddeebd
sbernard31 added a commit that referenced this issue May 30, 2018
@sbernard31
#429 : Raise CodecExpection if 2 node with same Id in json decoder
caa23c0
@sbernard31 sbernard31 mentioned this issue May 30, 2018
Merged
sbernard31 added a commit that referenced this issue Jun 7, 2018
@sbernard31
#429 : add tests for tlv about 2 node with same Id
4b6c499
sbernard31 added a commit that referenced this issue Jun 7, 2018
@sbernard31
#429 : Raise CodecExpection if 2 node with same Id in TLV decoder
932bd6b
sbernard31 added a commit that referenced this issue Jun 7, 2018
@sbernard31
#429 : add tests for json about 2 node with same Id
d2ff1db
sbernard31 added a commit that referenced this issue Jun 7, 2018
@sbernard31
#429 : Raise CodecExpection if 2 node with same Id in json decoder
3fa5953
sbernard31 added a commit that referenced this issue Jun 7, 2018
@sbernard31
#429 : Raise CodecExpection if 2 node with same Id in json decoder
7ce3ead
@sbernard31
Copy link
Contributor Author

It should be fixed in master since #511 is integrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bsserver Impact LWM2M bootstrap server client Impact LWM2M client new feature New feature from LWM2M specification server Impact LWM2M server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbernard31