Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityCheck#checkRpkIdentity could throw NullPointerException #443

Closed
AlexITC opened this issue Nov 28, 2017 · 3 comments
Closed

SecurityCheck#checkRpkIdentity could throw NullPointerException #443

AlexITC opened this issue Nov 28, 2017 · 3 comments
Labels
bug Dysfunctionnal behavior

Comments

@AlexITC
Copy link
Contributor

AlexITC commented Nov 28, 2017

The SecurityCheck#checkRpkIdentity method could throw a NullPointerException when publicKey is null and debug log level is enabled.

@sbernard31 sbernard31 added the bug Dysfunctionnal behavior label Nov 29, 2017
@sbernard31
Copy link
Contributor

I don't think publickey can be null as we check in caller method Identity.isRPK().
But at SecurityCheck#checkRpkIdentity level the code is no so clean and securityInfo.getRawPublicKey() can be null.
So you're right, we could improve this.

@AlexITC
Copy link
Contributor Author

AlexITC commented Nov 29, 2017

I'm not sure about that because I have not worked with RPK, I found the possible issue while digging into the code, I might upload a patch once I have some time.

sbernard31 added a commit that referenced this issue May 30, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mmarchini mary marchini
sbernard31 added a commit that referenced this issue Jun 7, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mmarchini mary marchini
@sbernard31
Copy link
Contributor

This should be fixed in master since #512 is integrated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Dysfunctionnal behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants