Remove lazy loading for getSupportedObjects in Registration. #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
force-pushed
the
refactor_get_supported_object
branch
from
a5538de to
7ba642a
Compare
msangoi
approved these changes
Jun 3, 2021
| @@ -157,18 +157,10 @@ public void test_object_links_with_text_in_not_lwm2m_path() { | |||
| assertEquals("1.1", supportedObject.get(3)); | |||
| } | |||
|
|
|||
| @Test | |||
| @Test(expected = IllegalArgumentException.class) | |||
| public void test_object_links_with_text_in_lwm2m_path() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the past
getSupportedObjectswas added in "Lazy loading" way.But there is now more and more data to extract from LinkObject :
It sounds better parse ObjectLink and extract data only when needed, then use classic serialize/deserialize for those data. (and so for supported objects too)