Refactoring Bootstrap Server (again) #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
BootstrapSessionManager is now responsible to handle all the logic for 1 session : This brings a lot of flexibility for someone who want to implement any kind of behavior. Now this is this class which know which requests to send during a bootstrap session.
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
After more thoughts, we decide that this was not the good approach. See #437 (comment) for more details. Consequences BootstrapConfig is no more deprecated.
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
The DefaultBootstrapSessionManager delegates knowledge of requests to send to BootstrapTaskProvider. A SimpleBootstrapStoreTaskProvider use BootstrapConfigStore to know which requests must be sent from BootstrapConfig.
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
This class are already needed by DefaultBootstrapSessionManager some one could create a BootstrapSessionManager which does not use it.
sbernard31
added a commit
that referenced
this pull request
Jun 10, 2021
BootstrapSessionManager is now responsible to handle all the logic for 1 session : This brings a lot of flexibility for someone who want to implement any kind of behavior. Now this is this class which know which requests to send during a bootstrap session.
After more thoughts, we decide that this was not the good approach. See #437 (comment) for more details. Consequences BootstrapConfig is no more deprecated.
Using Manual serialization like default JSON one is the preferred way.
The DefaultBootstrapSessionManager delegates knowledge of requests to send to BootstrapTaskProvider. A SimpleBootstrapStoreTaskProvider use BootstrapConfigStore to know which requests must be sent from BootstrapConfig.
This class are already needed by DefaultBootstrapSessionManager some one could create a BootstrapSessionManager which does not use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tries about making bootstrap server more flexible.
Thoughts which led to this PR are explained here : #437
Main changes was :
BootstrapConfigurationfrom Refactor BootstrapConfigStore to use a list of "request" #883BootstrapConfigis no more deprecated... 😬BootstrapSessionManageris now responsible to handle all the logic for 1 session : This brings a lot of flexibility for someone who want to implement any kind of behavior.BootstrapHandleris now just responsible to ensure there is only 1 session at a time for a given client and send requests provided byBootstrapSessionManagerone by one.DefaultBootstrapSessionManagerimplements default logic and delegates knowledge of requests to send toBootstrapTaskProvider.BootstrapConfigStoreTaskProvideruseBootstrapConfigStoreto know which requests must be sent fromBootstrapConfig.This sounds maybe a bit complicated but the idea is
BootstrapConfigStoreBootstrapConfigStoreTaskProvideror create your ownBootstrapTaskProviderDefaultBootstrapSessionManageror create your ownBootstrapSessionManagerThis should cover almost all use cases hiding complexity for most of users.