Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Link resource type support #1259

Closed
wants to merge 15 commits into from
Closed

Core Link resource type support #1259

wants to merge 15 commits into from

Conversation

jvermillard
Copy link
Contributor

Signed-off-by: Julien Vermillard jvermillard@sierrawireless.com

@jvermillard jvermillard requested a review from sbernard31 May 29, 2022 08:56
Copy link
Contributor

@sbernard31 sbernard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is lot of formatting issue 😬 but this is common issue from contribution where eclipse is not used 😞
(Tthis is probably a topic to address but hard to put it in priority list)

If I didn't missed something for now you only target TEXT and TLV correct ? any reason to not support other content format ?

You should also add coreLink support to LwM2mTestObject class
So you can easily test it with leshan-client-demo and leshan-server-demo.

@sbernard31
Copy link
Contributor

@jvermillard I push some more code. You can review it if you want.

With my last commit, you should be able to test coreLink with leshan-client-demo, try to play with object 3442 and Randomize, Reset, Clear, CoreLnk Value and Multiple CoreLink value resources.

About tests, we should add integration tests, at least in WriteSingleValueTest, this will create a test for all content format.
(I don't know if keep the unit test LwM2mNodeDecoderTest 🤔)

We should also add support of write coreLink in leshan-server-demo.

And also support for other content format.

@sbernard31
Copy link
Contributor

sbernard31 commented Jun 2, 2022

(I found a kind of bug with link serialization with rootpath but as this is not related to this PR, I try to fix this in another commit or PR)

@sbernard31
Copy link
Contributor

I finally added :

  • write support
  • WriteSingleValueTest
  • and support for other decoder/encoder

@jvermillard
Copy link
Contributor Author

Perfect 👍 Thanks for the help

@sbernard31
Copy link
Contributor

Integrated in master (commit d5e5a7d)
(I updated supported feature page : https://github.com/eclipse/leshan/wiki/LWM2M-1.1-supported-features)

Thx @jvermillard 🙏

@sbernard31 sbernard31 closed this Jun 3, 2022
@sbernard31 sbernard31 removed their request for review June 3, 2022 09:44
@sbernard31 sbernard31 deleted the corelnk branch June 3, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants