-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core Link resource type support #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is lot of formatting issue 😬 but this is common issue from contribution where eclipse is not used 😞
(Tthis is probably a topic to address but hard to put it in priority list)
If I didn't missed something for now you only target TEXT and TLV correct ? any reason to not support other content format ?
You should also add coreLink support to LwM2mTestObject class
So you can easily test it with leshan-client-demo and leshan-server-demo.
leshan-core/src/main/java/org/eclipse/leshan/core/node/codec/tlv/LwM2mNodeTlvDecoder.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/node/codec/tlv/LwM2mNodeTlvDecoder.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/node/codec/tlv/LwM2mNodeTlvDecoder.java
Outdated
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/node/LwM2mSingleResource.java
Show resolved
Hide resolved
leshan-core/src/main/java/org/eclipse/leshan/core/node/codec/tlv/LwM2mNodeTlvEncoder.java
Outdated
Show resolved
Hide resolved
leshan-core/src/test/java/org/eclipse/leshan/core/node/codec/LwM2mNodeDecoderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Julien Vermillard <jvermillard@sierrawireless.com>
@jvermillard I push some more code. You can review it if you want. With my last commit, you should be able to test coreLink with leshan-client-demo, try to play with object 3442 and Randomize, Reset, Clear, CoreLnk Value and Multiple CoreLink value resources. About tests, we should add integration tests, at least in WriteSingleValueTest, this will create a test for all content format. We should also add support of write coreLink in leshan-server-demo. And also support for other content format. |
(I found a kind of bug with link serialization with rootpath but as this is not related to this PR, I try to fix this in another commit or PR) |
I finally added :
|
Perfect 👍 Thanks for the help |
Integrated in Thx @jvermillard 🙏 |
Signed-off-by: Julien Vermillard jvermillard@sierrawireless.com