-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests write attributes #1587
Integration tests write attributes #1587
Conversation
❌ Code is not well-formatted ! (more details) Ensure your code build locally using:
Or just validate code format with :
You can format the code with :
See also How configure your IDE. |
ℹ️ Some tips :
If documentation or those automatic comments are not clear enough, please create a new issue to discus about how to enhance it. |
❌ Maven Build failed ! (more details) Ensure your code build locally using:
|
(I edited the PR to target branch |
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
I advice you to read specifications (see #534 (comment)) (maybe this is already done 😁) I guess it should help to identify how attributes should interact with each other and so which kind of combination makes sense to test. 🙂 |
(Also keep in mind that current implement doesn't probably implement expected behavior. So do not write tests in function of current code behavior 🙂) |
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
...src/test/java/org/eclipse/leshan/integration/tests/attributes/WriteAttributeObserveTest.java
Show resolved
Hide resolved
25d903f
to
54e8552
Compare
7e09aba
to
886c62c
Compare
I rebase this work on |
(see PR #1514) |
Following tests: