Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests write attributes #1587

Conversation

mgdlkundera
Copy link
Contributor

Following tests:

  • test about epmin, epmax,
  • test about pmin = pmax,
  • test where we use several attribute together,
  • test to be sure that attribute inheritance works.

Copy link

Code is not well-formatted ! (more details)

Ensure your code build locally using:

mvn clean install

Or just validate code format with :

mvn formatter:validate

You can format the code with :

mvn formatter:format

See also How configure your IDE.

Copy link

ℹ️ Some tips :

If documentation or those automatic comments are not clear enough, please create a new issue to discus about how to enhance it.

Copy link

Maven Build failed ! (more details)

Ensure your code build locally using:

mvn clean install

@sbernard31 sbernard31 changed the base branch from master to write_attributes February 21, 2024 10:38
@sbernard31
Copy link
Contributor

(I edited the PR to target branch write_attributes instead of master)

@sbernard31
Copy link
Contributor

sbernard31 commented Feb 21, 2024

I advice you to read specifications (see #534 (comment)) (maybe this is already done 😁)

I guess it should help to identify how attributes should interact with each other and so which kind of combination makes sense to test. 🙂

@sbernard31
Copy link
Contributor

(Also keep in mind that current implement doesn't probably implement expected behavior. So do not write tests in function of current code behavior 🙂)

@sbernard31 sbernard31 force-pushed the integration_tests_write_attributes branch from 7e09aba to 886c62c Compare March 1, 2024 10:03
@sbernard31 sbernard31 merged commit 886c62c into eclipse-leshan:write_attributes Mar 1, 2024
1 check passed
@sbernard31
Copy link
Contributor

I rebase this work on writes_attributes branch and it is now integrated in this branch.

@sbernard31
Copy link
Contributor

(see PR #1514)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants