#732: fix rt and ver attributes of Link format. #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msangoi
approved these changes
Jan 3, 2020
sbernard31
force-pushed
the
no_handshake_for_UQ_device
branch
from
0454e9b to
ed9e8ad
Compare
sbernard31
force-pushed
the
link_format
branch
from
3938e72 to
8120415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #732.
About
verattributeThe lwm2m specification v1.0.x seems to not be clear about the use of quote
"forvervalue :</55>;ver=1.9,</44>;ver=“2.2”The version v1.1.x both examples seem to not use quote and the format is clearly defined in §5.1.2. Attributes Classification :
"ver" "=" 1*DIGIT "." 1*DIGIT, so quote MUST NOT be used in v1.1.x.Regarding this, we choose to be able to read (server side) both quoted and unquoted value and we will write(client) it without using quote.
About
rt="oma.lwm2m"attributeThere is nothing clear in the specification neither in v1.0.x nor v1.1.x, but all example use quote (
"oma.lwm2m").Following the rfc669 quote could be used or not for single rt value.
So we choose to be able to read (server side) both quoted and unquoted value and we will write(client) it with quote (like in lwm2m example).