Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to recent BND #776

Closed
laeubi opened this issue Dec 15, 2023 · 8 comments
Closed

Upgrade to recent BND #776

laeubi opened this issue Dec 15, 2023 · 8 comments

Comments

@laeubi
Copy link

laeubi commented Dec 15, 2023

A recent discussion in OSGi-WG channels has shown that lsp4j uses bnd plugin in a "deprecated way", as I'm not familar enough with gradle I can only copy some instructions here that might be usefull for the maintainers of this project to upgrade given by @bjhargrave:

They are also using the bnd plugin in the old deprecated way. It should be jar.bundle.bnd and not jar.bnd. That is, the bnd DSL element has moved under the bundle DSL element. See https://github.com/bndtools/bnd/wiki/Changes-in-6.0.0#bnd-gradle-plugins for the bullet about gradle deprecation of conventions.

@cdietrich
Copy link
Contributor

cdietrich commented Dec 31, 2023

from that page you linked i cannot derive anything.
=> stupidly replace jar.bnd with jar.bundle.bnd and binary compare resulting jars?

can you also point to said discussion?

cdietrich added a commit that referenced this issue Dec 31, 2023
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
cdietrich added a commit that referenced this issue Dec 31, 2023
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@cdietrich
Copy link
Contributor

we also use more stuff that is deprecated in newer gradle versions

@cdietrich
Copy link
Contributor

cdietrich commented Dec 31, 2023

is anyone using the gradle ide task? does anyone know how to use it?

@cdietrich
Copy link
Contributor

new bnd needs j17 to run build

cdietrich added a commit that referenced this issue Jan 18, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@jonahgraham
Copy link
Contributor

is anyone using the gradle ide task? does anyone know how to use it?

Does this refer to the contents of https://github.com/eclipse-lsp4j/lsp4j/tree/db27a95ff71f6892074df6c404560c05f55552bc/ide ? If so, I don't think anyone is using them, if they are the references in them are really out of date. The underlying gradle plug-in is also "mostly abandoned" (diffplug/goomph#189) so I think we can remove it without further thought.

image

jonahgraham added a commit that referenced this issue Feb 12, 2024
Part of #776 (comment)

See [CONTRIBUTING.md](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CONTRIBUTING.md)
for instructions on how to setup an IDE for LSP4J development.
cdietrich added a commit that referenced this issue Feb 12, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
jonahgraham added a commit that referenced this issue Feb 12, 2024
cdietrich added a commit that referenced this issue Feb 12, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
cdietrich added a commit that referenced this issue Feb 12, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
cdietrich added a commit that referenced this issue Feb 12, 2024
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

fix some gradle deprecations

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

update to gradle 8.5

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>

downgrade bnd plugin again

Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
@jonahgraham
Copy link
Contributor

is anyone using the gradle ide task? does anyone know how to use it?

Does this refer to the contents of https://github.com/eclipse-lsp4j/lsp4j/tree/db27a95ff71f6892074df6c404560c05f55552bc/ide ? [...]

Removed in #794

@cdietrich
Copy link
Contributor

nice

@jonahgraham
Copy link
Contributor

#781 modernizes gradle usage (thanks @cdietrich for doing the heavy lifting)

new bnd needs j17 to run build

Because of this we are not at this time upgrading to bnd 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants