Various minor changes #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Brown <Kamasutra318@gmail.com>
|
@KamasamaK thanks for doing this cleanup. I have only reviewed as far as the changelog and that was fine by me. |
cdietrich
reviewed
May 12, 2022
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/services/LanguageServer.java
Show resolved
Hide resolved
cdietrich
reviewed
May 12, 2022
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/services/LanguageServer.java
Show resolved
Hide resolved
cdietrich
reviewed
May 12, 2022
|
javadoc changes look suspicious. tags dont seem to be closed |
|
Just a note that it does not seem required to close these tags in Javadoc, as examples in https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html show. Not closing these tags also matches common practice in other parts of LSP4J code base, including |
Merged
|
understood |
cdietrich
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
RenameOptions.idas it was already deprecated and never specified forStaticRegistrationOptionsSemanticTokenTypes.Memberas it was already deprecated and is not specifiedTraceValue.Messageas it was already deprecated and is not specifiedTraceValueto befinalmatching similar classesResponseErrorCodeas it has been deprecated for several versionsResponseErrorCode.serverErrorStartandResponseErrorCode.serverErrorEndas they were already deprecated and just boundaries not actual error codesOther changes
Protocol.xtend