-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Jakarta websocket from 2.0.0 to 2.1.0 #661
Conversation
it allows to be compatible with latest Tyrus RFC implementation 2.1.0 see https://jakarta.ee/specifications/websocket/2.1/ and https://github.com/eclipse-ee4j/tyrus/releases/tag/2.1.0 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Can one of the admins verify this patch? |
How is the orbit side of this gonna be addressed |
I would like to suggest to replace InstallableUnit-Location that contains Jakarta websocket, guava and gson with a corresponding Maven target. This would allow you to fetch those artifacts from Maven Central without the need to maintain/wait for Orbit. |
we might to do |
I am quite keen on what @merks has been working on in https://download.eclipse.org/oomph/simrel-maven/ too. |
As you prefer, both sounds good. And one glory day we maybe even get automated Updates via dependabot: If you later still prefer a Single Location for 3ed Party deps, switching to Ed's solution should be easy too. |
Ok. If that works we'll take it. I have no objection to the maven in target, but it needs pgp setup too for the project and may need tycho version bump too. |
We now consume the latest jakarta websocket version from Orbit - see #791 This change is sort of orthogonal as it sets the minimum version. Should we make the minimum 2.1.1 as that is the version we get from Orbit, and the latest version on Maven Central (its the same jar in both places BTW - its just that Orbit makes it nicely into a p2 site) |
I don't think we need to change the minimum version as I don't think we have requirements on newer version. If needed, please rebase the commit and reopen. |
it allows to be compatible with latest Tyrus RFC implementation 2.1.0 see https://jakarta.ee/specifications/websocket/2.1/ and https://github.com/eclipse-ee4j/tyrus/releases/tag/2.1.0
Note: