Skip to content

Commit

Permalink
Migrate RCPTT test for MavenTargetDependencyEditor to SWTBot
Browse files Browse the repository at this point in the history
In the long run, using RCPTT is probably causing more trouble than it's
worth. It therefore makes sense to switch to a more lightweight solution
like SWTBot for testing.
  • Loading branch information
ptziegler authored and akurtakov committed Oct 3, 2024
1 parent aa4f825 commit 7c195df
Show file tree
Hide file tree
Showing 19 changed files with 592 additions and 461 deletions.
2 changes: 1 addition & 1 deletion org.eclipse.m2e.pde.target/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.27.0,4.0.0)",
org.eclipse.m2e.maven.runtime;bundle-version="[3.8.0,4.0.0)",
org.eclipse.m2e.core;bundle-version="[2.0.0,3.0.0)",
org.eclipse.core.resources
Export-Package: org.eclipse.m2e.pde.target;x-friends:="org.eclipse.m2e.pde.ui",
Export-Package: org.eclipse.m2e.pde.target;x-friends:="org.eclipse.m2e.pde.ui,org.eclipse.m2e.swtbot.tests",
org.eclipse.m2e.pde.target.shared;x-internal:=true
Bundle-ActivationPolicy: lazy
Import-Package: aQute.bnd.osgi;version="[5.5.0,8.0.0)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.Status;
import org.eclipse.pde.core.target.ITargetLocation;
import org.eclipse.pde.core.target.ITargetLocationFactory;
import org.eclipse.pde.internal.core.ifeature.IFeature;
import org.w3c.dom.Document;
Expand All @@ -44,7 +43,7 @@ public class MavenTargetLocationFactory implements ITargetLocationFactory {
private static final String ATTRIBUTE_DEPENDENCY_SCOPE = "includeDependencyScope";

@Override
public ITargetLocation getTargetLocation(String type, String serializedXML) throws CoreException {
public MavenTargetLocation getTargetLocation(String type, String serializedXML) throws CoreException {
try {
Element location = parseXMLDocument(serializedXML).getDocumentElement();

Expand Down
1 change: 1 addition & 0 deletions org.eclipse.m2e.pde.ui/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Bundle-ManifestVersion: 2
Bundle-Name: M2E PDE Integration UI
Bundle-SymbolicName: org.eclipse.m2e.pde.ui;singleton:=true
Bundle-Version: 2.1.0.qualifier
Export-Package: org.eclipse.m2e.pde.ui.target.editor;x-friends:="org.eclipse.m2e.swtbot.tests"
Automatic-Module-Name: org.eclipse.m2e.pde.ui
Bundle-RequiredExecutionEnvironment: JavaSE-21
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.19.0",
Expand Down
23 changes: 0 additions & 23 deletions org.eclipse.m2e.rcptt.tests/.project

This file was deleted.

44 changes: 0 additions & 44 deletions org.eclipse.m2e.rcptt.tests/pom.xml

This file was deleted.

9 changes: 0 additions & 9 deletions org.eclipse.m2e.rcptt.tests/rcptt.properties

This file was deleted.

Loading

0 comments on commit 7c195df

Please sign in to comment.