Remove Maven Build shortcut

[laeubi]

Now we show the launch configs in the menu already, the Run As > Maven Build can be removed as it is obsolete now:

• if no config is there it is equivalent to the dialog variant
• if there is a config it is already shown as menu item

[github-actions]

Test Results

106 files  ±0  106 suites  ±0   11m 10s ⏱️ -29s
657 tests ±0  647 ✔️ ±0  10 💤 ±0  0 ❌ ±0 
657 runs  ±0  646 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 3ccc72d. ± Comparison against base commit 1cf7ac2.

♻️ This comment has been updated with latest results.

[laeubi]

@mickaelistria would you mind asking Redhat to assign an unused resource pack to m2eclipse? I noticed that Jenkins is currently way behind because it lacking executors when we have multiple PRs pending.

[laeubi]

@HannesWell @mickaelistria @fbricon any concerns?

[mickaelistria]

+1 for it. This will usually save opening a dialog.

[fbricon]

Why can't we build the PRs on Github Actions only? The only reason why we're using jenkins is so that we can sign the artifacts on the Eclipse infra and push CI builds to the snapshots area. PRs don't need any of that.

[mickaelistria]

We need to detect errors ASAP, including the ones related to signing.

[fbricon]

We need to detect errors ASAP, including the ones related to signing.

No signing is happening on PR builds. Only master and version branches get signed:

m2e-core/Jenkinsfile

Lines 46 to 48 in 1cf7ac2

	if [[ ${BRANCH_NAME} == master ]] || [[ ${BRANCH_NAME} =~ m2e-[0-9]+\\.[0-9]+\\.x ]]; then
	mvn ${mavenArgs} -Peclipse-sign,its -Dgpg.passphrase="${KEYRING_PASSPHRASE}" -Dgpg.keyname="011C526F29B2CE79"
	else

[laeubi]

I think in the past it was valuable to have some different system and setup to test, and assume the Jenkins build as the ultimate check as if it fails there after the fact its quite annoying, so unless we can get rid of Jenkins CI completely I think it should stay for PRs as well.