-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify pom co-ordinates when found via a relative path (fixes #482) #483
Conversation
When resolving a parent POM via a relative path verify that any POM found has co-ordinates that match the parent being sought.
I am struggling to run tests locally in my Eclipse IDE (installed via the m2e oomph setup). Does anyone know how best to fix the following error:
|
Fix test by including missing profile from the maven Settings file that has been added. fixes eclipse-m2e#482
I am struggling to work out why the @mickaelistria, have you previously seen any error like the error log I presented in my previous comment? Any ideas on how to fix this so that I can run tests locally in my IDE? |
I have seen it a few times when the org.eclipse.m2e.maven.runtime bundles have some trouble. But to be honest, @HannesWell changed many things (for the better) in how they were built lately and I didn't have the need/opportunity to re-look at them since then, and I never ever have used Oomph for m2e so I don't think I can be much helpful. |
The error listed above was due to not running the Maven Launch-Configuration 'm2e-maven-runtime--generate-OSGi-metadata' in my IDE prior to running the tests. I have run the above Maven goal and I am now able to run and debug the tests locally 👍 |
Did you only use the Oomph Installer do install your Eclipse IDE or did you also use the m2e Oomph setup? |
Update submodule commit hash to link to.
Is the mentioned launch-config configured in the Maven lifecycle as well? Or only executed on each start of the workspace? I cleaned the modules in my workspace at one point - so that may explain it. |
This PR is failing due to tests in the separate Git submodule: https://github.com/tesla/m2e-core-tests. I have created a PR for updating the failing test which should be safe without the changes in this code. It is a speculative fix - more details can be found in the PR: tesla/m2e-core-tests#134 Is there a way to run CI of this PR against my fork of the https://github.com/tesla/m2e-core-tests repo, or generally a better way of verifying these two changes together? |
This actually sounds like the correct workflow.
At the moment it is unfortunately not part of the M2E workspace build and only executed on each start or if you manually perform all setup tasks or run it directly. |
You can simply run the launch-config |
Nice, the standardisation changes you have been making since I last made a change to this project have been helpful already 👍. In the interim if anyone encounters this edge case hopefully their search will find this ticket for the simple solution.
Yes, that worked great. However, I only ran these tests individually via a JUnit run configuration (and they passed) rather than via the integration Maven launch config you mentioned - so that may explain why I failed to reproduce the issue. Next time I will see if that helps - thanks! |
@mickaelistria - thank you for merging tesla/m2e-core-tests#134. It looks like the speculative fix to a seemingly unimpacted test has worked - so I think this PR is ready to be reviewed in consideration for being merged. |
Thanks! |
When resolving a parent POM via a relative path verify that any POM found has co-ordinates that match the parent being sought.