[189] Mosquitto database corrupted on power-loss. #206
Conversation
Mosquitto database writes are not atomic and if power is lost during a write the file will be permanently lost. This commit makes writes as atomic as possible. Signed-off-by: Keegan Callin <kc@kcallin.net> Bug: eclipse-mosquitto#189
|
Issue tracker reference: |
|
Initial tests show that on Linux 4.1 persistence is working as well as it did before the patch. I have two boards in reboot rigs to practically verify that the new (more atomic) write procedure doesn't break as far as we can test. The practical testing will take another ~2 weeks to complete. I think that the change should be merged if there's any risk of conflicts with other pending changes in the next two weeks. If there's no risk then let's wait for the outcome of the practical tests. |
|
Mechanical hardware testing is complete. The test rig completed 15k power cycles without failure. Formerly we would see failures in ~1-2k cycles. Recommend merging. |
|
Thanks for this, I don't seem to have had a notification about your last message so only just saw it. I'll see about merging later today. |
Mosquitto database writes are not atomic and if power is lost during
a write the file will be permanently lost. This commit makes writes as
atomic as possible.
Signed-off-by: Keegan Callin kc@kcallin.net
Bug: #189