Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate commons.logging and log4j-1 loggers to SLF4J #296

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Contributor

This is a draft of the work to unify the logging frameworks used in MWE to use only slf4j and at the same time to migrate off commons.logging and log4j-1.

Currently this only contains the changes in java-code and the removal of the then obsolete logging frameworks from the target-platform, features, etc.

What's missing is the migration of the (log4j-1) configuration and the addition of a logging back-end slf4j can use.
My suggestion is to use slf4j-simple as a back-end.

The changes to adapt the projects that contain workflows to generate for example xtext DSLs are also missing because I don't know yet where to change that.
Furthermore the log4j.properties have to be migrated to the back-end chosen eventually. E.g. for slf4j-simple the doc is:
https://www.slf4j.org/api/org/slf4j/simple/SimpleLogger.html

This would help to solve eclipse-xtext/xtext#3127 at MWE side.

@cdietrich what do you think?

@cdietrich
Copy link
Contributor

I have no capacity to think currently

my problem is that such a solution has to work ganzheitlich.
Also with Xtext consuming mwe
How new Xtext project wizard creates stuff
How stuff is logged if you execute from
Maven gradle launch config in eclipse etc

@HannesWell
Copy link
Contributor Author

my problem is that such a solution has to work ganzheitlich.

Sure. I was already thinking about enhancing the MWE2 launcher to automatically add the additional bundles required to run the worklow, that are currently defined as 'development'-bundles using additional.bundles in the build.properties.

This would have the advantage that

  1. these definitions in the build.properties are not necessary anymore
  2. the requirements (like in this case) can be changed easily, only the launcher has to be adapted.

@HannesWell HannesWell force-pushed the migrate-off-commons.logging-and-log4j1 branch from af9c226 to 51ca8c9 Compare August 12, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants