Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip l2a if the memory reference has unresolved snippet #7014

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented May 30, 2023

Do not skip l2a if the memory reference has unresolved snippet.

Fixes: #17240

a7ehuo added 3 commits May 30, 2023 12:33
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
Copy link
Contributor Author

a7ehuo commented May 30, 2023

@0xdaryl May I ask you to review this change? Thank you!

@zl-wang @r30shah fyi

@a7ehuo
Copy link
Contributor Author

a7ehuo commented May 31, 2023

x86-64 macOS failed. Known issue: #6516

32: [  FAILED  ] PortSockTest.poll_functionality_basic (1036 ms)
32: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:51: Failure
32:       Expected: privateOmrPortLibrary->sock_bind(privateOmrPortLibrary, *serverSocket, serverSockAddr)
32:       Which is: -506
32: To be equal to: 0
32: /Users/runner/work/1/s/fvtest/porttest/omrsockTest.cpp:1259: Failure
32:       Expected: privateOmrPortLibrary->sock_accept(privateOmrPortLibrary, serverSocket, &connectedServerSockAddr, &connectedServerSocket)
32:       Which is: -20
32: To be equal to: 0
32: [  FAILED  ] PortSockTest.poll_functionality_many_sockets (2 ms)
32: [----------] 19 tests from PortSockTest (1045 ms total)
32: 
32: [==========] 246 tests from 21 test cases ran. (205258 ms total)
32: [  PASSED  ] 244 tests.
32: [  FAILED  ] 2 tests, listed below:
32: [  FAILED  ] PortSockTest.poll_functionality_basic
32: [  FAILED  ] PortSockTest.poll_functionality_many_sockets
32: 
32:  2 FAILED TESTS
32:   YOU HAVE 3 DISABLED TESTS
32: 
32: Some textSome text
44/47 Test #32: porttest ............................***Failed  205.49 sec

@0xdaryl
Copy link
Contributor

0xdaryl commented Jun 1, 2023

Jenkins build all

@0xdaryl 0xdaryl self-assigned this Jun 1, 2023
@0xdaryl 0xdaryl merged commit 0e57234 into eclipse-omr:master Jun 1, 2023
@a7ehuo a7ehuo deleted the fix-missing-l2a-evaluation-3 branch June 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SC_Softmx_JitAot_Linux Invalid class pointer assert MarkingSchemeRootMarker.cpp:48
2 participants