Define jitThrowIdentityException helper and isIdentityObject non-helper #7674
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <isIdentityObject> non-helper can be used by downstream projects as a way of distinguishing in IL whether an object is an instance of a class for which each instance has a unique identity, sometimes called an identity type, versus an instance of a class for which instances that have the same value are indistinguishable, sometimes called a value type. The <jitThrowIdentityException> helper can be used by downstream projects in IL to throw an IdentityException. It would typically be used to report that an object was expected to be an instance of a class for which each instance has a unique identity. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
requested review from
vijaysun-omr,
dsouzai,
0xdaryl and
mstoodle
as code owners
hzongaro
requested review from
a7ehuo
and removed request for
mstoodle,
dsouzai and
vijaysun-omr
|
Jenkins build all |
0xdaryl
approved these changes
Feb 28, 2025
a7ehuo
reviewed
Feb 28, 2025
Yes! Thank you for catching that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<isIdentityObject>non-helper can be used by downstream projects as a way of distinguishing in IL whether an object is an instance of a class for which each instance has a unique identity, sometimes called an identity type, versus an instance of a class for which instances that have the same value are indistinguishable, sometimes called a value type.The
<jitThrowIdentityException>helper can be used by downstream projects in IL to throw anIdentityException. It would typically be used to report that an object was expected to be an instance of a class for which each instance has a unique identity.