-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK18 OpenJDK test failures #13946
Comments
@ChengJin01 Can please add jdk18 excludes for all the tests that are known to not work @babsingh Please do the same for MH related tests |
@tajila Do we analyze the issues which need to be fixed, and create a standalone issue for each unique failure? |
Yes please |
It seems there are mainly two type of failures for these FFI related test suites:
In addition, all upcall related test suites should be excluded as the work for upcall is still underway. |
The majority of FFI related to test suites ended up with an assertion as follows in
against the code at https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/src/java.base/share/classes/java/lang/invoke/MemberName.java
The issue was likely introduced by the changes at #13890 in native at /runtime/jcl/common/java_lang_invoke_MethodHandleNatives.cpp, which has nothing to with the FFI specific tests. FYI: @babsingh, @fengxue-IS |
By disabling the assertion in code above, the actually results of the FFI specific test suites are as follows with the missing code/exception updated in code (phase 2 & 3 / struct support) at #13315 [1] test suites mixed with primitive & struct in downcall (should be excluded for the moment till the code at phase 2 & 3 is merged) [2] upcall related test suites (should be excluded as the development is still underway) [3] VaList related test suites (should be excluded for the moment till the code at phase 2 & 3 is merged) [4] Hotspot related test suites (should be excluded as these tests are specific to the implementation in Hotspot) e.g. java/foreign/stackwalk/TestAsyncStackWalk.java#shenandoah
I will create a PR at https://github.com/adoptium/aqa-tests to exclude these test suites. |
@ChengJin01 Please provide #13993 as the associated issue while excluding the |
re #13946 (comment):
Does the assertion error go away after reverting 305ee16? |
I didn't try reverting but disabled the assertion as it is irrelevant to the foreign specific code. |
re #13946 (comment):
I reverted 305ee16 and reran one of the failing tests which cause an |
The |
Tests failures documented in the below issues have been excluded: 1) eclipse-openj9/openj9#13995 2) eclipse-openj9/openj9#13996 3) eclipse-openj9/openj9#13997 4) eclipse-openj9/openj9#13998 Parent issue: eclipse-openj9/openj9#13946 The tests will be re-enabled once they are fixed. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
We might want to wait until we get #14077 merged so we can run the latest OpenJDK code again, and get an updated list of failures. |
We've updated to the latest OpenJDK and the following failures remain
@JasonFengJ9 opened #14134 for TestUpcall, #14131 for the finalization failures, #14133 for DelegateTest, #14132 for WithClassLoaderName, #14136 for TestInferCaller. We should get all of these tests excluded until they can be fixed so we can run green and use sanity.openjdk in the promotion criteria for accepting further OpenJDK updates. |
I don't yet see an issue for java/foreign/upcalldeopt/TestUpcallDeopt.java |
Included it at #14134 (comment) |
The failing FFI related test suites are new ones added in the latest version of Java 18, which should be excluded as well. |
@ChengJin01 can you exclude the foreign failures, and @JasonFengJ9 can exclude the others. |
Created adoptium/aqa-tests#3172 to exclude failures other than |
Actually I'm reopening this as there are failures on other platforms which we still need to deal with. |
AIX: zlinux: Mac: Windows: |
Another run with the latest excludes https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK18/1/ AIX: plinux: zlinux: xlinux: Mac: Windows: |
Many of the failures in the last couple of comments have cleared up. We'll handle the remaining failures with individual issues. |
All platforms https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/157/
https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.openjdk_aarch64_linux_OpenJDK/1/#showFailuresLink
java/foreign/SafeFunctionAccessTest.java.SafeFunctionAccessTest
java/foreign/SafeFunctionAccessTest.java.SafeFunctionAccessTest
java/foreign/StdLibTest.java.StdLibTest
java/foreign/StdLibTest.java.StdLibTest
java/foreign/TestDowncall.java.TestDowncall
java/foreign/TestDowncall.java.TestDowncall
java/foreign/TestIllegalLink.java.TestIllegalLink
java/foreign/TestIllegalLink.java.TestIllegalLink
java/foreign/TestIntrinsics.java.TestIntrinsics
java/foreign/TestIntrinsics.java.TestIntrinsics
java/foreign/TestNULLAddress.java.TestNULLAddress
java/foreign/TestNULLAddress.java.TestNULLAddress
java/foreign/TestNative.java.TestNative
java/foreign/TestNative.java.TestNative
java/foreign/TestUpcall.java.TestUpcall
java/foreign/TestUpcall.java.TestUpcall
java/foreign/TestUpcallException.java.TestUpcallException
java/foreign/TestUpcallException.java.TestUpcallException
java/foreign/TestUpcallHighArity.java.TestUpcallHighArity
java/foreign/TestUpcallHighArity.java.TestUpcallHighArity
java/foreign/TestUpcallStructScope.java.TestUpcallStructScope
java/foreign/TestUpcallStructScope.java.TestUpcallStructScope
java/foreign/TestVarArgs.java.TestVarArgs
java/foreign/TestVarArgs.java.TestVarArgs
java/foreign/malloc/TestMixedMallocFree.java.TestMixedMallocFree
java/foreign/malloc/TestMixedMallocFree.java.TestMixedMallocFree
java/foreign/stackwalk/TestAsyncStackWalk.java#default_gc.TestAsyncStackWalk_default_gc
java/foreign/stackwalk/TestAsyncStackWalk.java#default_gc.TestAsyncStackWalk_default_gc
java/foreign/stackwalk/TestAsyncStackWalk.java#shenandoah.TestAsyncStackWalk_shenandoah
java/foreign/stackwalk/TestAsyncStackWalk.java#shenandoah.TestAsyncStackWalk_shenandoah
java/foreign/stackwalk/TestAsyncStackWalk.java#zgc.TestAsyncStackWalk_zgc
java/foreign/stackwalk/TestAsyncStackWalk.java#zgc.TestAsyncStackWalk_zgc
java/foreign/stackwalk/TestStackWalk.java#default_gc.TestStackWalk_default_gc
java/foreign/stackwalk/TestStackWalk.java#default_gc.TestStackWalk_default_gc
java/foreign/stackwalk/TestStackWalk.java#shenandoah.TestStackWalk_shenandoah
java/foreign/stackwalk/TestStackWalk.java#shenandoah.TestStackWalk_shenandoah
java/foreign/stackwalk/TestStackWalk.java#zgc.TestStackWalk_zgc
java/foreign/stackwalk/TestStackWalk.java#zgc.TestStackWalk_zgc
java/foreign/valist/VaListTest.java.VaListTest
java/foreign/valist/VaListTest.java.VaListTest
java/foreign/virtual/TestVirtualCalls.java.TestVirtualCalls
java/foreign/virtual/TestVirtualCalls.java.TestVirtualCalls
java/lang/StringBuilder/HugeCapacity.java.HugeCapacity
java/lang/StringBuilder/HugeCapacity.java.HugeCapacity
java/lang/System/AllowSecurityManager.java.AllowSecurityManager
java/lang/System/AllowSecurityManager.java.AllowSecurityManager
java/lang/System/FileEncodingTest.java.FileEncodingTest
java/lang/System/FileEncodingTest.java.FileEncodingTest
java/lang/System/SecurityManagerWarnings.java.SecurityManagerWarnings
java/lang/System/SecurityManagerWarnings.java.SecurityManagerWarnings
java/lang/Thread/UncaughtExceptionsTest.java.UncaughtExceptionsTest
java/lang/Thread/UncaughtExceptionsTest.java.UncaughtExceptionsTest
java/lang/annotation/LoaderLeakTest.java.LoaderLeakTest
java/lang/annotation/LoaderLeakTest.java.LoaderLeakTest
java/lang/annotation/typeAnnotations/GetAnnotatedOwnerType.java.GetAnnotatedOwnerType
java/lang/annotation/typeAnnotations/GetAnnotatedOwnerType.java.GetAnnotatedOwnerType
java/lang/annotation/typeAnnotations/TestExecutableGetAnnotatedType.java.TestExecutableGetAnnotatedType
java/lang/annotation/typeAnnotations/TestExecutableGetAnnotatedType.java.TestExecutableGetAnnotatedType
java/lang/annotation/typeAnnotations/TestObjectMethods.java.TestObjectMethods
java/lang/annotation/typeAnnotations/TestObjectMethods.java.TestObjectMethods
java/lang/constant/MethodHandleDescTest.java.MethodHandleDescTest
java/lang/constant/MethodHandleDescTest.java.MethodHandleDescTest
java/lang/invoke/7087570/Test7087570.java.Test7087570
java/lang/invoke/7087570/Test7087570.java.Test7087570
java/lang/invoke/7157574/Test7157574.java.Test7157574
java/lang/invoke/7157574/Test7157574.java.Test7157574
java/lang/invoke/7196190/ClassForNameTest.java.ClassForNameTest
java/lang/invoke/7196190/ClassForNameTest.java.ClassForNameTest
java/lang/invoke/7196190/GetUnsafeTest.java.GetUnsafeTest
java/lang/invoke/7196190/GetUnsafeTest.java.GetUnsafeTest
java/lang/invoke/8177146/TestMethodHandleBind.java.TestMethodHandleBind
java/lang/invoke/8177146/TestMethodHandleBind.java.TestMethodHandleBind
java/lang/invoke/InvokeDynamicPrintArgs.java.InvokeDynamicPrintArgs
java/lang/invoke/InvokeDynamicPrintArgs.java.InvokeDynamicPrintArgs
java/lang/invoke/JavaDocExamplesTest.java.JavaDocExamplesTest
java/lang/invoke/JavaDocExamplesTest.java.JavaDocExamplesTest
java/lang/invoke/MethodHandlesProxiesTest.java.MethodHandlesProxiesTest
java/lang/invoke/MethodHandlesProxiesTest.java.MethodHandlesProxiesTest
java/lang/invoke/callerSensitive/Main.java.Main
java/lang/invoke/callerSensitive/Main.java.Main
java/lang/invoke/lambda/InheritedMethodTest.java.InheritedMethodTest
java/lang/invoke/lambda/InheritedMethodTest.java.InheritedMethodTest
java/lang/invoke/lambda/MetafactoryArgValidationTest.java.MetafactoryArgValidationTest
java/lang/invoke/lambda/MetafactoryArgValidationTest.java.MetafactoryArgValidationTest
java/lang/invoke/lambda/invokeSpecial/InvokeSpecialMethodTest.java.InvokeSpecialMethodTest
java/lang/invoke/lambda/invokeSpecial/InvokeSpecialMethodTest.java.InvokeSpecialMethodTest
java/lang/invoke/lookup/ChainedLookupTest.java.ChainedLookupTest
java/lang/invoke/lookup/ChainedLookupTest.java.ChainedLookupTest
java/lang/invoke/lookup/SpecialStatic.java.SpecialStatic
java/lang/invoke/lookup/SpecialStatic.java.SpecialStatic
java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java.DefaultStaticInvokeTest
java/lang/reflect/DefaultStaticTest/DefaultStaticInvokeTest.java.DefaultStaticInvokeTest
java/lang/reflect/MethodHandleAccessorsTest.java#id0.MethodHandleAccessorsTest_id0
java/lang/reflect/MethodHandleAccessorsTest.java#id0.MethodHandleAccessorsTest_id0
java/lang/reflect/MethodHandleAccessorsTest.java#id1.MethodHandleAccessorsTest_id1
java/lang/reflect/MethodHandleAccessorsTest.java#id1.MethodHandleAccessorsTest_id1
java/lang/reflect/Parameter/InnerClassToString.java.InnerClassToString
java/lang/reflect/Parameter/InnerClassToString.java.InnerClassToString
java/lang/reflect/Proxy/DefaultMethods.java.DefaultMethods
java/lang/reflect/Proxy/DefaultMethods.java.DefaultMethods
java/lang/reflect/Proxy/ProxyTest.java.ProxyTest
java/lang/reflect/Proxy/ProxyTest.java.ProxyTest
java/lang/reflect/Proxy/nonPublicProxy/DefaultMethodProxy.java.DefaultMethodProxy
java/lang/reflect/Proxy/nonPublicProxy/DefaultMethodProxy.java.DefaultMethodProxy
java/lang/reflect/classInitialization/ExceptionInClassInitialization.java.ExceptionInClassInitialization
java/lang/reflect/classInitialization/ExceptionInClassInitialization.java.ExceptionInClassInitialization
java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java.CallerAccessTest
java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java.CallerAccessTest
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id0.GetCallerClassTest_id0
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id0.GetCallerClassTest_id0
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id1.GetCallerClassTest_id1
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id1.GetCallerClassTest_id1
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id2.GetCallerClassTest_id2
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id2.GetCallerClassTest_id2
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id3.GetCallerClassTest_id3
jdk/internal/reflect/Reflection/GetCallerClassTest.java#id3.GetCallerClassTest_id3
@tajila fyi
The text was updated successfully, but these errors were encountered: