Skip to content

Remove _magic_ constant J9_FFI_DOWNCALL_HEAP_ARGUMENT_ID #19005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
keithc-ca opened this issue Feb 23, 2024 · 2 comments · Fixed by #19649
Closed

Remove _magic_ constant J9_FFI_DOWNCALL_HEAP_ARGUMENT_ID #19005

keithc-ca opened this issue Feb 23, 2024 · 2 comments · Fixed by #19649
Assignees
@ChengJin01
Labels
comp:vm jdk22 jdk23 project:panama Used to track Project Panama related work

Comments

@keithc-ca
Copy link
Contributor

J9_FFI_DOWNCALL_HEAP_ARGUMENT_ID was originally 0x1, but changed to 0xFFFFFFFFFFFFFFFF in #19002. No matter what value is chosen, it's possible it conflicts with application intent. As I suggested, I think we should use an out-of-band channel to distinguish parameters that should point within the heap from other parameters.
@keithc-ca
Copy link
Contributor Author

FYI @ChengJin01.

@keithc-ca keithc-ca mentioned this issue Feb 23, 2024
Merged
@ChengJin01
Copy link

ChengJin01 commented Jun 4, 2024 •
edited
Loading

Instead of relying on J9_FFI_DOWNCALL_HEAP_ARGUMENT_ID which might cause conflict with the malicious address imposed by users, I think the problem can be resolved by checking the existence of heapBase in which case heapBase is set to null in terms of a native array (a non-null heapBase object denotes a heap array). I will create a patch with the solution to see whether it works good as expected.

ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 7, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5feb2e7 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 self-assigned this Jun 7, 2024
@ChengJin01 ChengJin01 added jdk22 jdk23 comp:vm project:panama Used to track Project Panama related work labels Jun 7, 2024
@ChengJin01 ChengJin01 mentioned this issue Jun 7, 2024
Merged
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 7, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
e811e9d 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 7, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
3577798 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 7, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
f13b9ad 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 7, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
1ee69c5 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 11, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
bb6deb3 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 11, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
ba8a777 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
ChengJin01 pushed a commit to ChengJin01/openj9 that referenced this issue Jun 11, 2024
[FFI/JDK22+] Remove the heap argument identifier in downcall
ac7713d 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
pshipton pushed a commit to pshipton/openj9 that referenced this issue Jul 24, 2024
@pshipton
[FFI/JDK22+] Remove the heap argument identifier in downcall
f4515fd 
The changes aim to avoid the conflicts of the native address
imposed by users by check the existence of the heap base to
determine whether a heap array rather than a native array
is passed down to native.

Fixes: eclipse-openj9#19005

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengJin01 ChengJin01

Labels
comp:vm jdk22 jdk23 project:panama Used to track Project Panama related work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FFI/JDK22+] Remove the heap argument identifier in downcall ChengJin01/openj9
2 participants
@keithc-ca @ChengJin01