Fix testSCCacheManagement failure on ibm 11 zos #10368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hangshao0 @llxia Could you review it? Thanks. |
|
Test link in Internal Grinder: |
hangshao0
reviewed
Aug 11, 2020
| @@ -164,14 +164,18 @@ public static void main(String args[]) { | |||
| } | |||
| for(String cacheName: nonpersistentList) { | |||
| if (cacheName.indexOf("groupaccess") != -1) { | |||
| runSimpleJavaProgramWithNonPersistentCache(cacheName, "groupAccess"); | |||
| if (isOpenJ9()) { | |||
There was a problem hiding this comment.
This check affects all platforms, but the original issue complains only about z/OS.
|
This PR has been temporarily changed to Draft mode, since the test failure may be caused by JDK build error, opened another issue on on Internal GitHub runtimes/openj9-openjdk-jdk11-zos/issues/360 |
- fix cache location change because ibm 11+ use -DOPENJ9_BUILD setting [ci skip] Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
|
Test Links: vmfarm: 461152 jdk 11:
jdk 8:
|
|
lgtm. @hangshao0 pls review. |
hangshao0
approved these changes
Dec 7, 2020
pshipton
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci skip]
Signed-off-by: Longyu Zhang longyu.zhang@ibm.com