-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid the static initialization of class in getCPMethodHandleAt #10410
Avoid the static initialization of class in getCPMethodHandleAt #10410
Conversation
Reviewer: @DanHeidinga |
Currently have some issue with personal builds (Joe is working on that). Will wait till the problem out there gets resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick but overall this looks like the right change to me
The change is to avoid initializing the specified class in getCPMethodHandleAt so as to postpone the static initialization to the invocation of the method of this class. Fixes: eclipse-openj9#10356 Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
960d8e8
to
ac3cd72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ChengJin01 can you confirm this matches the RI's behaviour in JDK8 & 11 as well? |
Jenkins test sanity zlinux jdk8 |
Jenkins test sanity xlinux jdk11 |
Jenkins test sanity win jdk15 |
@DanHeidinga , I just checked Java 8 & 11/Hotspot with the testcases (Test, Test2 and Test3) verified in #10356, which ended up with the same results as our build with my fix. [1] The latest nightly build for Java 8/Hotspot downloaded from AdoptOpenJDK at https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u-2020-08-17-17-05/OpenJDK8U-jdk_x64_linux_hotspot_2020-08-17-17-05.tar.gz
[2] The latest nightly build for Java 11/Hotspot downloaded from AdoptOpenJDK at https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/download/jdk11u-2020-08-12-08-12/OpenJDK11U-jdk_x64_linux_hotspot_2020-08-12-08-12.tar.gz
|
The change is to avoid initializing the specified class
in getCPMethodHandleAt so as to postpone the static
initialization to the invocation of the method of this class.
Fixes: #10356
Signed-off-by: Cheng Jin jincheng@ca.ibm.com