Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cmdLineTester_GCCheck into openj9 #11682

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Port cmdLineTester_GCCheck into openj9 #11682

merged 1 commit into from
Jan 26, 2021

Conversation

OscarQQ
Copy link
Contributor

@OscarQQ OscarQQ commented Jan 19, 2021

related: backlog issue 434
Signed-off-by: OscarQQ Yixin.Qian@ibm.com

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jan 19, 2021 •
edited
Loading

Build Platform Java Version JDK Impl
Grinder/13386/ ppc64_aix,ppc64le_linux,s390x_linux,x86-64_linux,x86-64_mac,x86-64_windows 8,11 OpenJ9
Grinder/13403/ zos 11 OpenJ9

llxia
llxia reviewed Jan 19, 2021
View reviewed changes
test/functional/cmdLineTests/gcCheck/build.xml Outdated Show resolved Hide resolved
test/functional/cmdLineTests/gcCheck/build.xml Outdated Show resolved Hide resolved
test/functional/cmdLineTests/gcCheck/playlist.xml Outdated Show resolved Hide resolved
test/functional/cmdLineTests/gcCheck/playlist.xml Outdated Show resolved Hide resolved
@llxia
Copy link
Contributor

llxia commented Jan 19, 2021

Please make sure this test pass on zos and vmfarm. Thanks

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Jan 19, 2021 •
edited
Loading

I have seen intermittent failures on the macos platform e.x. https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5994/, https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/5978/

01:27:48  Test result: FAILED
01:27:48  Output from test:
01:27:48   [OUT] success!
01:27:48   [ERR] JVMDUMP039I Processing dump event "vmstop", detail "#0000000000000000" at 2021/01/19 09:27:42 - please wait.
01:27:48   [ERR] JVMDUMP032I JVM requested System dump using '/Users/jenkins/workspace/Grinder/openjdk-tests/TKG/test_output_16110484601484/cmdLineTester_GCCheck_SE80_1/j9core.dmp' in response to an event
01:27:48   [ERR] JVMDUMP012E Error in System dump: The core file created by child process with pid = 24390 was not found. Expected to find core file with name "/cores/core.24390"
01:27:48   [ERR] JVMDUMP013I Processed dump event "vmstop", detail "#0000000000000000".
01:27:48  >> Success condition was not found: [Output match: System dump written]

Other platforms have no problems so far
@pshipton could you take a look? thank you!

updated: sorry I am now trying internal machines

@pshipton
Copy link
Member

I don't think creating core files on Mac works when you have a signed build (as produced at AdoptOpenJDK) and the OS is 10.15+. Although the machine seems to be 10.14 in this case. Not sure how Adopt is handling this problem in other testing.

This should work in the builds at OpenJ9 as these builds are not signed. These all passed. 1440 and 1442 are 10.14 machines.
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1436
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1438
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1439
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1440
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1441
https://ci.eclipse.org/openj9/view/Test/job/Grinder/1442

@OscarQQ OscarQQ marked this pull request as ready for review January 19, 2021 23:23
@fjeremic
Copy link
Contributor

The PR title is a bit misleading. I thought at first we're talking about the !gccheck jdmpview command, but in fact this porting the GCCheck tests into OpenJ9. Could we adjust the PR title, and while at it fix up the commit title as well to be consistent with the contribution guidelines:

The first line should be less than 70 characters, where reasonable, and should be written in sentence case (capitalize the first letter) preferably not ending in a period.

https://github.com/eclipse/openj9/blob/master/CONTRIBUTING.md#commit-guidelines

@OscarQQ OscarQQ changed the title port gccheck into openj9 Port cmdLineTester_GCCheck into openj9 Jan 20, 2021
@OscarQQ OscarQQ force-pushed the test10 branch 3 times, most recently from d4c2cb0 to be31ab2 Compare January 21, 2021 07:49
@OscarQQ
Port cmdLineTester_GCCheck into openj9
03bffdf 
related: backlog issue 434
[ci skip]

Signed-off-by: Yixin Qian <Yixin.Qian@ibm.com>
@llxia
Copy link
Contributor

llxia commented Jan 22, 2021

Jenkins test sanity win,xlinux,aix jdk8,jdk11

llxia
llxia approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 653858e into eclipse-openj9:master Jan 26, 2021
@pshipton pshipton mentioned this pull request Jan 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton left review comments

@llxia llxia llxia approved these changes

@fjeremic fjeremic fjeremic approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OscarQQ @llxia @pshipton @fjeremic