Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency between J9Class and annotation data when redefine (take 2) #14063

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Fix inconsistency between J9Class and annotation data when redefine (take 2) #14063

merged 2 commits into from
Dec 3, 2021

Conversation

EricYangIBM
Copy link
Contributor

This reverts commit 06ae571.
Fixes a cast causing failures on 32 bit systems.

Closes: #10026
Signed-off-by: Eric Yang eric.yang@ibm.com

@EricYangIBM
Revert "Revert "Fix inconsistency between J9Class and annotation data…
3037ba8 
… when redefine""

This reverts commit 06ae571.

Closes: eclipse-openj9#10026
Signed-off-by: Eric Yang eric.yang@ibm.com
@EricYangIBM
Fix cast
b07a6f8
@EricYangIBM EricYangIBM mentioned this pull request Dec 2, 2021
Closed
@tajila
Copy link
Contributor

tajila commented Dec 2, 2021

Jenkins test sanity win jdk8

@tajila
Copy link
Contributor

tajila commented Dec 2, 2021

Jenkins test sanity plinux jdk11,17

@keithc-ca
Copy link
Contributor

Jenkins test sanity win32 jdk8

@keithc-ca
Copy link
Contributor

Jenkins test sanity plinux jdk17

('17' is not a version understood by jenkins)

@keithc-ca
Copy link
Contributor

Jenkins test sanity plinux jdk11

(It seems jdk11 was skipped because jenkins didn't understand '17')

@keithc-ca keithc-ca changed the title Revert "Revert "Fix inconsistency between J9Class and annotation data when redefine"" Fix inconsistency between J9Class and annotation data when redefine (take 2) Dec 2, 2021
@tajila
Copy link
Contributor

tajila commented Dec 3, 2021

thanks @keithc-ca that was a typo

@tajila
Copy link
Contributor

tajila commented Dec 3, 2021 •
edited
Loading

Seems like a network issue is causing the jdk17 test failure

18:28:21  git clone --depth 1 -b master https://github.com/eclipse-openj9/openj9.git
18:28:42  fatal: unable to access 'https://github.com/eclipse-openj9/openj9.git/': gnutls_handshake() failed: Error in the pull function.

Ill respin

@tajila
Copy link
Contributor

tajila commented Dec 3, 2021

Jenkins test sanity plinux jdk17

@EricYangIBM
Copy link
Contributor Author

New test failure: #14066

@EricYangIBM
Copy link
Contributor Author

Could it be due to reverting the PR?

@pshipton
Copy link
Member

pshipton commented Dec 3, 2021

Maybe something is inconsistent in the internal builds? There wasn't any problem in the open nightly builds.

@EricYangIBM
Copy link
Contributor Author

EricYangIBM commented Dec 3, 2021 •
edited
Loading

The PR was merged 24 hours ago, reverted 21 hours ago but the tests were started 1d 2h ago. The exact test was started 10:14 EST which is when the PR was in the head stream

@tajila
Copy link
Contributor

tajila commented Dec 3, 2021 •
edited
Loading

I think there may have been a mismatch between the JDK and the test source.

It says:

[2021-12-02T15:48:45.330Z] ---SUMMARY OF FAILED TESTS---
[2021-12-02T15:48:45.330Z] rc021

So it definitely picked up the new test that you added.

But


[2021-12-02T15:14:28.437Z]  [ERR] 	Error: 103   JVMTI_ERROR_ILLEGAL_ARGUMENT
[2021-12-02T15:14:28.437Z]  [ERR] 		Unknown testcase: [rc021]
[2021-12-02T15:14:28.437Z]  [ERR] 
[2021-12-02T15:14:28.437Z]  [ERR] 		Location: null -> [null():0]

Seems to imply that the jvmtitest lib doesnt have the latest changes. The jvmtitest lib is built with the JDK IIRC.

@EricYangIBM
Copy link
Contributor Author

Running zos tests again: https://hyc-runtimes-jenkins.swg-devops.com/job/jvm.29.personal/30183/

@tajila tajila merged commit 5afc033 into eclipse-openj9:master Dec 3, 2021
@EricYangIBM EricYangIBM deleted the fixCast branch December 3, 2021 21:09
@yaohwu
Copy link

yaohwu commented Dec 6, 2021

🎉

@pshipton pshipton mentioned this pull request Dec 8, 2021
Open
@mikezhang1234567890 mikezhang1234567890 mentioned this pull request Sep 14, 2022
Merged
theresa-m added a commit to theresa-m/openj9-openjdk-jdk8 that referenced this pull request Nov 10, 2023
@theresa-m
Fix extensions annotation and constantpool inconsistencies
6c8473b 
Missing cases from eclipse-openj9/openj9#14063

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m added a commit to theresa-m/openj9-openjdk-jdk8 that referenced this pull request Nov 10, 2023
@theresa-m
Fix extensions annotation and constantpool inconsistencies
87413fb 
Missing cases from eclipse-openj9/openj9#14063

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Class's annotation cache more resilient across redefines
5 participants
@EricYangIBM @tajila @keithc-ca @pshipton @yaohwu