Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DDR support for AArch64 macOS #14921

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Apr 19, 2022

This commit adds support for AArch64 core files on macOS in DDR.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Apr 19, 2022

jenkins test sanity.functional,extended.functional xmac jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Apr 19, 2022

This PR does not enable DDR on AArch64 macOS yet.

@knn-k
Copy link
Contributor Author

knn-k commented Apr 19, 2022

Following is an example of reading a core file from AArch64 macOS using jdmpview on AArch64 Linux. It is a Java backtrace of the "Common-Cleaner" thread.

> !stack 0x13981d700
<13981d700>     !j9method 0x00000001401F8428   java/lang/Object.wait(JI)V
<13981d700>     !j9method 0x00000001401F8408   java/lang/Object.wait(J)V
<13981d700>     !j9method 0x0000000118368E18   java/lang/ref/ReferenceQueue.remove(J)Ljava/lang/ref/Reference;
<13981d700>     !j9method 0x000000012810E150   jdk/internal/ref/CleanerImpl.run()V
<13981d700>     !j9method 0x000000014033FB90   java/lang/Thread.run()V
<13981d700>     !j9method 0x000000012810FB40   jdk/internal/misc/InnocuousThread.run()V
<13981d700>                             JNI call-in frame
<13981d700>                             Native method frame

@knn-k
Copy link
Contributor Author

knn-k commented Apr 19, 2022

The tests show that this PR does not break DDR on x86_64 macOS.

@knn-k knn-k marked this pull request as ready for review April 19, 2022 09:38
@0xdaryl
Copy link
Contributor

0xdaryl commented Apr 19, 2022

@keithc-ca : would you mind reviewing this PR please?

@knn-k
Copy link
Contributor Author

knn-k commented Apr 20, 2022

I updated the code a little.

@knn-k
Copy link
Contributor Author

knn-k commented Apr 20, 2022

jenkins test sanity.functional,extended.functional xmac jdk11

@keithc-ca keithc-ca self-requested a review April 20, 2022 11:33
@knn-k knn-k force-pushed the aarch64macos_ddr1 branch from 7e61b34 to f2c9c8c Compare April 21, 2022 23:46
@knn-k
Copy link
Contributor Author

knn-k commented Apr 21, 2022

jenkins test sanity xmac jdk11

@knn-k knn-k force-pushed the aarch64macos_ddr1 branch from f2c9c8c to df14d8c Compare April 22, 2022 01:02
@knn-k
Copy link
Contributor Author

knn-k commented Apr 22, 2022

jenkins test sanity xmac jdk11

@knn-k knn-k force-pushed the aarch64macos_ddr1 branch from df14d8c to c0bceec Compare April 25, 2022 13:13
@knn-k
Copy link
Contributor Author

knn-k commented Apr 25, 2022

jenkins test extended.functional xmac jdk11 depends eclipse-omr/omr#5800

@knn-k
Copy link
Contributor Author

knn-k commented Apr 26, 2022

jenkins test extended.functional xmac jdk11

@knn-k
Copy link
Contributor Author

knn-k commented Apr 26, 2022

I hope this PR to be merged soon so that jdmpview on other platforms can read core files from AArch64 macOS.

This commit adds support for AArch64 core files on macOS in DDR.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k force-pushed the aarch64macos_ddr1 branch from c0bceec to dc9f171 Compare April 27, 2022 23:50
@knn-k
Copy link
Contributor Author

knn-k commented Apr 27, 2022

jenkins test sanity xmac jdk11

@keithc-ca keithc-ca merged commit e74e3c3 into eclipse-openj9:master Apr 28, 2022
@knn-k knn-k deleted the aarch64macos_ddr1 branch April 28, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants