Improve error message when loading an invalid class version #15084

thallium · 2022-05-18T14:02:23Z

provides version number of invalid class

fix #13347

@fengxue-IS please review

Signed-off-by: Gengchen Tuo gengchen.tuo@ibm.com

runtime/nls/cfre/cfrerr.nls

runtime/verutil/cfrerr.c

pshipton · 2022-05-19T02:06:57Z

J9NLS_CFR_ERR_MAJOR_VERSION, J9NLS_CFR_ERR_MINOR_VERSION can't be removed completely, just the text can be removed. See the instructions at the top of the file # If you wish to remove a message, delete its text, but leave the key in place.

thallium · 2022-05-19T17:58:46Z

J9NLS_CFR_ERR_MAJOR_VERSION, J9NLS_CFR_ERR_MINOR_VERSION can't be removed completely, just the text can be removed. See the instructions at the top of the file # If you wish to remove a message, delete its text, but leave the key in place.

should = be removed?

pshipton · 2022-05-19T18:13:26Z

should = be removed?

The = should stay. You can also remove the values of the fields that follow, and set .explanation=NOTAG. Example

J9NLS_VM_DVT_NOT_SET=
# START NON-TRANSLATABLE
J9NLS_VM_DVT_NOT_SET.explanation=NOTAG
J9NLS_VM_DVT_NOT_SET.system_action=
J9NLS_VM_DVT_NOT_SET.user_response=
# END NON-TRANSLATABLE

runtime/verutil/cfrerr.c

runtime/nls/cfre/cfrerr.nls

runtime/verutil/cfrerr.c

thallium · 2022-05-20T19:11:48Z

Removed old preview version message and also squashed commits.

pshipton · 2022-05-20T20:02:10Z

@fengxue-IS any more comments?

jenking test sanity,extended xlinux jdk8

fengxue-IS

code lgtm, no more questions

fengxue-IS · 2022-05-20T20:19:08Z

jenking test sanity,extended xlinux jdk8

@pshipton can you please restart the testing, there is a typo

pshipton · 2022-05-20T20:26:57Z

jenkins test sanity,extended xlinux jdk8

pshipton · 2022-05-25T12:02:51Z

jenkins compile xlinux jdk18,jdk19

thallium · 2022-05-25T14:02:32Z

jenkins compile xlinux jdk18,jdk19

@pshipton Looks like it should be "next" instead of jdk19?

pshipton · 2022-05-25T14:27:41Z

jenkins compile xlinux jdk18,jdknext

pshipton · 2022-05-25T17:20:55Z

Major version too big:

Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=Wait, offset=6
	at java.lang.ClassLoader.defineClassImpl(Native Method)

Preview version on older JVM:

Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=Switch, offset=6
	at java.lang.ClassLoader.defineClassImpl(Native Method)

Preview not enabled:

Error: LinkageError occurred while loading main class Switch
	java.lang.UnsupportedClassVersionError: JVMCFRE197E version 62.65535 of class Switch is a preview version but preview is not enabled, please enable it with --enable-preview; offset=6

Unsupported preview version

Error: LinkageError occurred while loading main class Switch
	java.lang.UnsupportedClassVersionError: JVMCFRE198E version 61.65535 of class Switch is an unsupported preview major version, runtime only allows 62.65535; offset=6

runtime/nls/cfre/cfrerr.nls

thallium · 2022-05-25T21:04:53Z

Major version too big:

Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=Wait, offset=6
	at java.lang.ClassLoader.defineClassImpl(Native Method)

Preview version on older JVM:

Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.UnsupportedClassVersionError: JVMCFRE003 bad major version; class=Switch, offset=6
	at java.lang.ClassLoader.defineClassImpl(Native Method)

Preview not enabled:

Error: LinkageError occurred while loading main class Switch
	java.lang.UnsupportedClassVersionError: JVMCFRE197E version 62.65535 of class Switch is a preview version but preview is not enabled, please enable it with --enable-preview; offset=6

Unsupported preview version

Error: LinkageError occurred while loading main class Switch
	java.lang.UnsupportedClassVersionError: JVMCFRE198E version 61.65535 of class Switch is an unsupported preview major version, runtime only allows 62.65535; offset=6

What's the first two errors? Do I need to do something about them?

pshipton · 2022-05-25T21:12:12Z

They are just examples of your changes, for testing.

runtime/nls/cfre/cfrerr.nls

runtime/bcutil/cfreader.c

runtime/oti/j9nonbuilder.h

runtime/verutil/cfrerr.c

runtime/nls/cfre/cfrerr.nls

runtime/bcutil/cfreader.c

runtime/nls/cfre/cfrerr.nls

runtime/bcutil/cfreader.c

keithc-ca · 2022-05-31T19:11:45Z

@thallium Please resolve the conflict (your additions to cfrerr.nls should go at the end).

runtime/nls/cfre/cfrerr.nls

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>

keithc-ca · 2022-05-31T20:27:02Z

jenkins test sanity,extended alinux64,win,win32 jdk8

pshipton · 2022-06-01T01:28:09Z

@thallium pls cherry pick this change and create a PR against the https://github.com/eclipse-openj9/openj9/tree/v0.33.0-release branch.

thallium force-pushed the master branch 2 times, most recently from 988d054 to 30ca1b5 Compare May 18, 2022 14:08

fengxue-IS reviewed May 18, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

pshipton added the comp:vm label May 18, 2022

pshipton reviewed May 18, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

pshipton reviewed May 18, 2022

View reviewed changes

runtime/verutil/cfrerr.c Outdated Show resolved Hide resolved

runtime/verutil/cfrerr.c Outdated Show resolved Hide resolved

thallium force-pushed the master branch 2 times, most recently from d1514fa to 56ca1b2 Compare May 18, 2022 23:25

thallium force-pushed the master branch from 2e5fd7a to 2cf4b36 Compare May 19, 2022 18:30

pshipton reviewed May 19, 2022

View reviewed changes

runtime/verutil/cfrerr.c Outdated Show resolved Hide resolved

pshipton reviewed May 19, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

thallium force-pushed the master branch 2 times, most recently from a536c76 to 0d6991e Compare May 20, 2022 16:34

thallium requested a review from pshipton May 20, 2022 17:01

pshipton reviewed May 20, 2022

View reviewed changes

thallium force-pushed the master branch 2 times, most recently from a65b82a to a7c6194 Compare May 20, 2022 19:09

fengxue-IS approved these changes May 20, 2022

View reviewed changes

pshipton reviewed May 25, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

pshipton reviewed May 25, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

thallium force-pushed the master branch from a7c6194 to 0b75981 Compare May 25, 2022 20:43

pshipton reviewed May 25, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Outdated Show resolved Hide resolved

thallium force-pushed the master branch from 0b75981 to df930fb Compare May 25, 2022 21:40

pshipton approved these changes May 25, 2022

View reviewed changes

pshipton requested a review from keithc-ca May 25, 2022 21:48

keithc-ca requested changes May 26, 2022

View reviewed changes

thallium force-pushed the master branch 3 times, most recently from 73c276c to ecea610 Compare May 27, 2022 17:12

thallium requested a review from keithc-ca May 27, 2022 17:14

keithc-ca requested changes May 27, 2022

View reviewed changes

thallium force-pushed the master branch from ecea610 to 9e89b17 Compare May 27, 2022 22:08

thallium requested a review from keithc-ca May 27, 2022 22:43

keithc-ca reviewed May 30, 2022

View reviewed changes

runtime/bcutil/cfreader.c Outdated Show resolved Hide resolved

thallium force-pushed the master branch from 9e89b17 to 818795b Compare May 30, 2022 13:49

thallium force-pushed the master branch from cd752c5 to f67744a Compare May 31, 2022 19:37

keithc-ca reviewed May 31, 2022

View reviewed changes

runtime/nls/cfre/cfrerr.nls Show resolved Hide resolved

runtime/nls/cfre/cfrerr.nls Show resolved Hide resolved

thallium force-pushed the master branch from f67744a to e743f6b Compare May 31, 2022 20:00

Improve error message when loading an invalid class version

9794fee

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>

thallium force-pushed the master branch from e743f6b to 9794fee Compare May 31, 2022 20:17

keithc-ca approved these changes Jun 1, 2022

View reviewed changes

keithc-ca merged commit a091bb4 into eclipse-openj9:master Jun 1, 2022

This was referenced Jun 1, 2022

(0.33) Improve error message when loading an invalid class version #15159

Merged

WIP: Improve error message when loading an invalid class version #13347 #14236

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve error message when loading an invalid class version #15084

Improve error message when loading an invalid class version #15084

thallium commented May 18, 2022

pshipton commented May 19, 2022

thallium commented May 19, 2022

pshipton commented May 19, 2022

thallium commented May 20, 2022

pshipton commented May 20, 2022

fengxue-IS left a comment

fengxue-IS commented May 20, 2022

pshipton commented May 20, 2022

pshipton commented May 25, 2022

thallium commented May 25, 2022

pshipton commented May 25, 2022

pshipton commented May 25, 2022

thallium commented May 25, 2022

pshipton commented May 25, 2022

keithc-ca commented May 31, 2022

keithc-ca commented May 31, 2022

pshipton commented Jun 1, 2022

Improve error message when loading an invalid class version #15084

Improve error message when loading an invalid class version #15084

Conversation

thallium commented May 18, 2022

pshipton commented May 19, 2022

thallium commented May 19, 2022

pshipton commented May 19, 2022

thallium commented May 20, 2022

pshipton commented May 20, 2022

fengxue-IS left a comment

Choose a reason for hiding this comment

fengxue-IS commented May 20, 2022

pshipton commented May 20, 2022

pshipton commented May 25, 2022

thallium commented May 25, 2022

pshipton commented May 25, 2022

pshipton commented May 25, 2022

thallium commented May 25, 2022

pshipton commented May 25, 2022

keithc-ca commented May 31, 2022

keithc-ca commented May 31, 2022

pshipton commented Jun 1, 2022