Remove deprecated MXBean APIs & internal methods in Java 19 and 20 #15127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile win jdknext |
|
jenkins test sanity,extended alinux64 jdk8 |
|
jenkins test sanity,extended amac jdknext |
|
jenkins test sanity,extended amac jdknext |
|
jenkins compile win jdknext |
|
Testing via grinders: |
pshipton
changed the title
|
Re-run 19 JLM_Tests_interface with the fixes: |
keithc-ca
requested changes
May 27, 2022
.../jdk.management/share/classes/com/ibm/lang/management/internal/ExtendedMemoryMXBeanImpl.java
Outdated
Show resolved
Hide resolved
|
Updated to address comments. |
Removed in 19: ExtendedMemoryMXBeanImpl.getTotalPhysicalMemory() OperatingSystemMXBean.getTotalPhysicalMemory(), getProcessCpuTimeByNS(), getProcessVirtualMemorySize() RuntimeMXBean.getProcessID() Removed in 20: ExtendedMemoryMXBeanImpl.getTotalPhysicalMemorySize(), getUsedPhysicalMemory() Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Tweaked some other javadoc. |
keithc-ca
approved these changes
May 27, 2022
|
I'm satisfied that the recent changes don't invalidate the successful build at https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/2175/; I also did a local build to confirm the UMA changes are good. |
pshipton
added a commit
to pshipton/openj9-systemtest
that referenced
this pull request
May 30, 2022
Otherwise the test code does not compile on jdk19 where the methods are removed. See eclipse-openj9/openj9#15127 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-systemtest
that referenced
this pull request
May 30, 2022
Otherwise the test code does not compile on jdk19 where the methods are removed. See eclipse-openj9/openj9#15127 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-systemtest
that referenced
this pull request
May 30, 2022
Otherwise the test code does not compile on jdk19 where the methods are removed. See eclipse-openj9/openj9#15127 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in 19:
ExtendedMemoryMXBeanImpl.getTotalPhysicalMemory()
OperatingSystemMXBean.getTotalPhysicalMemory(), getProcessCpuTimeByNS(), getProcessVirtualMemorySize()
RuntimeMXBean.getProcessID()
Removed in 20:
ExtendedMemoryMXBeanImpl.getTotalPhysicalMemorySize(), getUsedPhysicalMemory()