Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -XX:+AllowNonVirtualCalls #15234

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Jun 6, 2022

Also replace "Java" with "OpenJDK" in recent release notes to match the convention.

@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

I've got the deprecation release note pointing to this PR. If there is a better issue to use pls let me know.

Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this also include the code changes to issue that warning (or error) for Java 20+?

doc/release-notes/0.33/0.33.md Outdated Show resolved Hide resolved
doc/release-notes/0.33/0.33.md Outdated Show resolved Hide resolved
@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

Updated.

@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

Made another update to replace "Java" with "OpenJDK". Also in older release notes.

@keithc-ca
Copy link
Contributor

When I spoke of code changes, I suppose I was expecting that jvminit.c#L3549 would change from

#if !defined(J9VM_OPT_VALHALLA_VALUE_TYPES)

to

#if (JAVA_SPEC_VERSION <= 19) && !defined(J9VM_OPT_VALHALLA_VALUE_TYPES)

(and the matching #endif would change to match).

@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

Yes, I originally missed that comment but was just starting to look at it. I was assuming that would be done separately, but no reason I can't add it to this PR.

@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

Updated now.

runtime/vm/jvminit.c Outdated Show resolved Hide resolved
doc/release-notes/0.33/0.33.md Outdated Show resolved Hide resolved
Also replace "Java" with "OpenJDK" in recent release notes to match the
convention.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Jun 6, 2022

Updated.

@keithc-ca
Copy link
Contributor

jenkins compile amac jdk17

@tajila tajila merged commit 14b70fd into eclipse-openj9:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants