add JVMTI callback/hook for virtualThread #15254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
requested changes
Jun 7, 2022
Comment on lines
+149
to
+150
| static void jvmtiHookVirtualThreadStarted (J9HookInterface** hook, UDATA eventNum, void* eventData, void* userData); | ||
| static void jvmtiHookVirtualThreadEnd (J9HookInterface** hook, UDATA eventNum, void* eventData, void* userData); |
There was a problem hiding this comment.
Suggested change
| static void jvmtiHookVirtualThreadStarted (J9HookInterface** hook, UDATA eventNum, void* eventData, void* userData); | |
| static void jvmtiHookVirtualThreadEnd (J9HookInterface** hook, UDATA eventNum, void* eventData, void* userData); | |
| static void jvmtiHookVirtualThreadStarted (J9HookInterface **hook, UDATA eventNum, void *eventData, void *userData); | |
| static void jvmtiHookVirtualThreadEnd (J9HookInterface **hook, UDATA eventNum, void *eventData, void *userData); |
There was a problem hiding this comment.
I am leaning towards keeping the existing format here, or else we could just change all the function headers to match standard
fengxue-IS
force-pushed
the
jvmti_stub
branch
2 times, most recently
from
88be440
to
18642a4
Compare
babsingh
approved these changes
Jun 8, 2022
tajila
approved these changes
Jun 9, 2022
tajila
reviewed
Jun 9, 2022
tajila
reviewed
Jun 10, 2022
fengxue-IS
force-pushed
the
jvmti_stub
branch
2 times, most recently
from
78ad61e
to
237b9f4
Compare
- New hook methods:
jvmtiHookVirtualThreadStarted
jvmtiHookVirtualThreadEnd
- Enable can_support_virtual_threads by default for Java19
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
|
Jenkins test sanity amac jdknext |
|
Jenkins test compile win jdknext |
|
amac compile passed, PR testing failed due to infra issue |
|
Jenkins test compile win jdknext |
|
Jenkins test sanity amac jdknext |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15183
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com