Prevent improper removal of static store in idiom recognition #15344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a static store could be marked negligible based on its uses in TR_CISCTransformer::simpleOptimization(), which could allow for the loop to be transformed in a way that removes the store. Issue: eclipse-openj9#15319
|
jenkins compile xlinux jdk8 |
|
Jenkins test sanity all jdk17 |
0xdaryl
approved these changes
Jun 21, 2022
|
I feel this is reasonably safe for 0.33. Do you agree @jdmpapin ? |
|
Yeah, I think it's pretty safe |
|
OK. I'll merge this now into master. Please create a 0.33 PR as well that we can merge after the head stream soaks for a day or so. @pshipton FYI. |
|
If things look good pls merge the 0.33 PR before the weekend. |
|
Opened #15386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a static store could be marked negligible based on its uses in
TR_CISCTransformer::simpleOptimization(), which could allow for the loop to be transformed in a way that removes the store.Issue: #15319