CRIU fix Timer.schedule test and show checkpointRestoreTimeDelta value #15350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Jun 16, 2022
keithc-ca
reviewed
Jun 16, 2022
* Removed elapsedTime < (MILLIS_DELAY_AFTERCHECKPOINTDONE + MAX_TARDINESS_MS)) (and a few others) which depend on the checkpoint process time. This test ensures that the scheduled task skips the JVM down time between checkpoint and restore, and won't be fired right after restore; * Set systemReturnCode w/ vm->portLibrary->checkpointRestoreTimeDelta, and to be printed out via J9NLS_JCL_CRIU_NEGATIVE_CHECKPOINT_RESTORE_TIME_DELTA. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
keithc-ca
approved these changes
Jun 20, 2022
tajila
approved these changes
Jun 21, 2022
|
Jenkins test sanity xlinuxcriu jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elapsedTime < (MILLIS_DELAY_AFTERCHECKPOINTDONE + MAX_TARDINESS_MS))(and a few others) which depend on the checkpoint process time. This test mainly ensures that the scheduled task skips the JVM down time between checkpoint and restore, and won't be fired right after restore. This addresses CRIU update TimerTask.nextExecutionTime with checkpointRestoreTimeDelta ibmruntimes/openj9-openjdk-jdk17#110 (comment) & CRIU update TimerTask.nextExecutionTime with checkpointRestoreTimeDelta ibmruntimes/openj9-openjdk-jdk#462 (comment);systemReturnCodew/vm->portLibrary->checkpointRestoreTimeDelta, and to be printed out viaJ9NLS_JCL_CRIU_NEGATIVE_CHECKPOINT_RESTORE_TIME_DELTA. This addresses CRIU throws RestoreException when checkpointRestoreTimeDelta is negative #15232 (comment).FYI @keithc-ca
Signed-off-by: Jason Feng fengj@ca.ibm.com