Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIU adjusts Object.wait/Thread.sleep/Unsafe.park #15499

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

JasonFengJ9
Copy link
Member

omrthread_monitor_wait, omrthread_sleep and omrthread_park are adjusted with j9time_nano_time() which already takes account of the checkpoint/restore down time;
Added tests;
Fixed trace points and messages.

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added comp:vm criu Used to track CRIU snapshot related work labels Jul 6, 2022
@JasonFengJ9 JasonFengJ9 requested a review from tajila July 6, 2022 22:15
@tajila
Copy link
Contributor

tajila commented Sep 21, 2022

please rebase changes

@tajila
Copy link
Contributor

tajila commented Sep 23, 2022

@ChengJin01 Please review

@JasonFengJ9
Copy link
Member Author

Rebased and modified according to recent CRIU changes.

FYI @tajila @ChengJin01

runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Show resolved Hide resolved
runtime/vm/threadhelp.cpp Show resolved Hide resolved
runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadpark.c Outdated Show resolved Hide resolved
@ChengJin01
Copy link

@llxia, please help check to see whether everything is correct in the test scripts.

@tajila
Copy link
Contributor

tajila commented Oct 9, 2022

Jenkins test sanity xlinuxcriu jdk17

@tajila
Copy link
Contributor

tajila commented Oct 9, 2022

jenkins test sanity win jdk17

@tajila
Copy link
Contributor

tajila commented Oct 12, 2022

jenkins test extended amac jdk17

runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadhelp.cpp Outdated Show resolved Hide resolved
runtime/vm/threadpark.c Outdated Show resolved Hide resolved
omrthread_monitor_wait, omrthread_sleep and omrthread_park are time
compensated with j9time_nano_time() which already takes account of the
checkpoint/restore down time;
Add timeCompensationHelper() used by three APIs above;
Add tests;
Fix trace points and messages;
Refactoring at functions impacted.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Member Author

Added timeCompensationHelper() shared by the three APIs.

@tajila this is ready for another look.

@tajila
Copy link
Contributor

tajila commented Oct 19, 2022

jenkins test sanity win jdk17

@tajila
Copy link
Contributor

tajila commented Oct 19, 2022

Jenkins test sanity xlinuxcriu jdk17

@tajila
Copy link
Contributor

tajila commented Oct 19, 2022

jenkins test extended amac jdk17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants