Return JVMTI_ERROR_OPAQUE_FRAME from ForceEarlyReturn* and PopFrame #15710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
loom_jvmti_2
branch
5 times, most recently
from
9aeb703
to
9e151cd
Compare
|
@keithc-ca Can you help review this PR? |
keithc-ca
requested changes
Aug 15, 2022
babsingh
force-pushed
the
loom_jvmti_2
branch
2 times, most recently
from
a8386b4
to
f51ff18
Compare
keithc-ca
reviewed
Aug 16, 2022
If the thread is a virtual thread, ForceEarlyReturn* and PopFrame JVMTI functions should return JVMTI_ERROR_OPAQUE_FRAME. Also, fixed the entry/exit tracepoints for ForceEarlyReturn* JVMTI functions. isSameOrSuperClassOf is unable to handle NULL from the *_OR_NULL version. Instead, use J9VMJAVALANGBASEVIRTUALTHREAD in IS_VIRTUAL_THREAD. Ref: https://download.java.net/java/early_access/jdk19/docs/specs/jvmti.html Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
jenkins test sanity amac jdk19 |
keithc-ca
approved these changes
Aug 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the thread is a virtual thread,
ForceEarlyReturn*andPopFrameJVMTIfunctions should return
JVMTI_ERROR_OPAQUE_FRAME.Also, fixed the
entry/exittracepoints forForceEarlyReturn*JVMTI functions.isSameOrSuperClassOfis unable to handleNULLfrom the*_OR_NULLversion.Instead, use
J9VMJAVALANGBASEVIRTUALTHREADinIS_VIRTUAL_THREAD.Ref: https://download.java.net/java/early_access/jdk19/docs/specs/jvmti.html
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com