Add class for OSR redefinition when removing a merged HCR guard #15726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an HCR guard was merged into another virtual guard, it could be removed without taking into account the class whose redefinition it guards against. If no other removed HCR guard was sensitive to redefinition of the same class, then no redefinition assumption would be made for that class. If that class were later redefined, the JIT would fail to patch OSR guards within the method. Additionally, use performTransformation() to make the removal optional like it is in the non-merged case above.
|
Jenkins test sanity all jdk17 |
0xdaryl
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an HCR guard was merged into another virtual guard, it could be removed without taking into account the class whose redefinition it guards against. If no other removed HCR guard was sensitive to redefinition of the same class, then no redefinition assumption would be made for that class. If that class were later redefined, the JIT would fail to patch OSR guards within the method.
Additionally, use
performTransformation()to make the removal optional like it is in the non-merged case above.