Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop registering class extend assumptions for HCR guards #15727

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

jdmpapin
Copy link
Contributor

Extending the defining class of an inlined method does not invalidate the bodies of methods defined by that class, which remain unchanged until/unless the class is actually redefined.

It's possible for a guard merged with an HCR guard to require a class extend assumption for its (non-HCR) virtual guard semantics. In that case, execution will continue on and create the class extend assumption in exactly the same way as it would without the merged HCR guard.

@0xdaryl 0xdaryl self-assigned this Aug 18, 2022
@0xdaryl
Copy link
Contributor

0xdaryl commented Aug 18, 2022

Please fix the copyright in CHTable.cpp

Extending the defining class of an inlined method does not invalidate
the bodies of methods defined by that class, which remain unchanged
until/unless the class is actually redefined.

It's possible for a guard merged with an HCR guard to require a class
extend assumption for its (non-HCR) virtual guard semantics. In that
case, execution will continue on and create the class extend assumption
in exactly the same way as it would without the merged HCR guard.
@jdmpapin
Copy link
Contributor Author

Updated the copyright header

@0xdaryl
Copy link
Contributor

0xdaryl commented Aug 18, 2022

Jenkins test sanity all jdk17

@0xdaryl 0xdaryl merged commit b4e513f into eclipse-openj9:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants