Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standalone JIT option -XX:[+|-]PerfTool #15823

Merged

Conversation

yathamravali
Copy link
Contributor

@yathamravali yathamravali commented Sep 5, 2022

When specifying multiple JIT options, currently only the last
JIT option will be in effect. Added a standalone alternative for
-Xjit:perfTool in -XX:+PerfTool to avoid clobbering pre-existing
JIT command line options.

New Options
-XX:+PerfTool Enables Perf Tool
-XX:-PerfTool Disables Perf Tool

Fixes: #14157
Signed-off-by: Ravali Yatham ravaliyatham@gmail.com

@yathamravali
Copy link
Contributor Author

@0xdaryl - Kindly review this PR.

runtime/compiler/control/DLLMain.cpp Outdated Show resolved Hide resolved
runtime/compiler/control/J9Options.cpp Outdated Show resolved Hide resolved
@yathamravali
Copy link
Contributor Author

@dsouzai - Incorporated suggested changes, PTAL.

@dsouzai
Copy link
Contributor

dsouzai commented Sep 7, 2022

jenkins test sanity all jdk17

@dsouzai
Copy link
Contributor

dsouzai commented Sep 7, 2022

@pshipton would something like this require documenting in the openj9 docs? It's basically an alias for perfTool in the -Xjit options.

@pshipton
Copy link
Member

pshipton commented Sep 7, 2022

Don't forget to open a doc issue for the new option.

@pshipton
Copy link
Member

pshipton commented Sep 7, 2022

would something like this require documenting in the openj9 docs? It's basically an alias for perfTool in the -Xjit options.

Is there some reason not to document it? We want it documented so it can be used.

@dsouzai
Copy link
Contributor

dsouzai commented Sep 7, 2022

Is there some reason not to document it? We want it documented so it can be used.

I was asking more as a process clarification.

@dsouzai
Copy link
Contributor

dsouzai commented Sep 7, 2022

I'm cancelling the build jobs because I realized the commits are not squashed. @yathamravali can you please squash your commits so that there's just one commit?

@dsouzai dsouzai self-assigned this Sep 7, 2022
When specifying multiple JIT options, currently only the last
JIT option will be in effect. Added a standalone alternative for
-Xjit:perfTool in -XX:+PerfTool to avoid clobbering pre-existing
JIT command line options.

New Options
-XX:+PerfTool Enables Perf Tool
-XX:-PerfTool Disables Perf Tool

Fixes: eclipse-openj9#14157
Signed-off-by: Ravali Yatham <ravaliyatham@gmail.com>
@yathamravali
Copy link
Contributor Author

@dsouzai - Squashed the commits.

@dsouzai
Copy link
Contributor

dsouzai commented Sep 7, 2022

jenkins test sanity all jdk17

@yathamravali yathamravali changed the title Add standalone JIT option -XperfTool Add standalone JIT option -XX:[+\-]PerfTool Sep 8, 2022
@yathamravali yathamravali changed the title Add standalone JIT option -XX:[+\-]PerfTool Add standalone JIT option -XX:[+|-]PerfTool Sep 8, 2022
@yathamravali
Copy link
Contributor Author

Opened doc issue for the new option - eclipse-openj9/openj9-docs#983

@yathamravali
Copy link
Contributor Author

@pshipton - Could you help with the release target to mention in doc issue please?

@dsouzai dsouzai merged commit d0ee05f into eclipse-openj9:master Sep 8, 2022
@pshipton
Copy link
Member

pshipton commented Sep 8, 2022

As it stands the change will be in the 0.36 release in Jan, but if it's low risk and @dsouzai agrees, you can open a PR to double deliver it to the v0.35.0-release branch to get it into the Oct release.

@dsouzai
Copy link
Contributor

dsouzai commented Sep 8, 2022

I'd say it's low risk as the default behaviour is unchanged. If the next release is all the way in Jan, then I suppose it makes sense to double deliver this for 0.35 if there's still time to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add standalone argument for -Xjit:perfTool to avoid clobbering pre-existing JIT tuning
3 participants