Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK19+ j9classshape outputs eetop instead of threadRef #15842

Merged
merged 1 commit into from
Sep 7, 2022
Merged

JDK19+ j9classshape outputs eetop instead of threadRef #15842

merged 1 commit into from
Sep 7, 2022

Conversation

JasonFengJ9
Copy link
Member

JDK19+ adopts OpenJDK java.lang.Thread, !j9classshape output contains eetop while the output from earlier Java levels are threadRef.

Verified at a local run.

closes #15252

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added the project:loom Used to track Project Loom related work label Sep 7, 2022
@pshipton
Copy link
Member

pshipton commented Sep 7, 2022

jdk8 failed to compile.
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/1267/console

14:34:18      [javac] /home/jenkins/workspace/Grinder/aqa-tests/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java:24: error: cannot find symbol
14:34:18      [javac] import org.openj9.test.util.VersionCheck;
14:34:18      [javac]                            ^
14:34:18      [javac]   symbol:   class VersionCheck
14:34:18      [javac]   location: package org.openj9.test.util
14:34:19      [javac] /home/jenkins/workspace/Grinder/aqa-tests/functional/DDR_Test/src/j9vm/test/ddrext/Constants.java:297: error: cannot find symbol
14:34:19      [javac] 	public static final String J9CLASSSHAPE_SUCCESS_KEY = (VersionCheck.major() >= 19 ? "eetop," : "threadRef,") + J9CLASS_TEST_SUCCESS_KEY;
14:34:19      [javac] 	                                                       ^
14:34:19      [javac]   symbol:   variable VersionCheck
14:34:19      [javac]   location: class Constants
14:34:19      [javac] 2 errors

@JasonFengJ9
JDK19+ j9classshape outputs eetop instead of threadRef
3e9ec10 
JDK19+ adopts OpenJDK java.lang.Thread, !j9classshape output contains
eetop while the output from earlier Java levels are threadRef.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9
Copy link
Member Author

Added TestUtilities src for Java 8, fixed the compilation error.

This PR is ready for another run.

@pshipton
Copy link
Member

pshipton commented Sep 7, 2022

Grinders for 8, 11 passed.

@pshipton pshipton merged commit 2712974 into eclipse-openj9:master Sep 7, 2022
@JasonFengJ9 JasonFengJ9 deleted the loomddr branch September 7, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:test project:loom Used to track Project Loom related work
Projects
None yet
Milestone
No milestone
2 participants
@JasonFengJ9 @pshipton