Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Exception message to Xdump stack agent output #15854

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add Exception message to Xdump stack agent output #15854

merged 1 commit into from
Oct 12, 2022

Conversation

imkabir
Copy link
Contributor

@imkabir imkabir commented Sep 9, 2022 •
edited
Loading

When Xdump:stack is used to dump stack trace filtered on an exception, this change along with the primary exception message, displays additional detail about the exception if any. This is similar to how javacore displays additional detail about an exception in 1TISIGINFO tag.

Fixes: #8435
Signed-off-by: Kabir Islam kaislam1@in.ibm.com

pshipton
pshipton reviewed Sep 9, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@imkabir
Copy link
Contributor Author

imkabir commented Sep 12, 2022

Thank you so much for your review @pshipton. I made the changes. Would appreciate you reviewing the changes. Thank you!

pshipton
pshipton reviewed Sep 12, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@imkabir
Copy link
Contributor Author

imkabir commented Sep 13, 2022

I made the changes. Thank you for your review @pshipton !

pshipton
pshipton reviewed Sep 13, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@pshipton
Copy link
Member

@keithc-ca

keithc-ca
keithc-ca requested changes Sep 13, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@imkabir imkabir force-pushed the 8435_feature branch 2 times, most recently from b4bd3f7 to 746a11d Compare September 14, 2022 09:16
@imkabir
Copy link
Contributor Author

imkabir commented Sep 14, 2022

Thank you so much for your comments @keithc-ca , thank you @pshipton. I have modified the code. Please check if this looks ok to you.

keithc-ca
keithc-ca requested changes Sep 14, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@imkabir
Copy link
Contributor Author

imkabir commented Sep 16, 2022

Thank you @keithc-ca! Corrected the code.

keithc-ca
keithc-ca requested changes Sep 16, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
@imkabir imkabir force-pushed the 8435_feature branch 2 times, most recently from c46cd36 to e691fa5 Compare September 23, 2022 11:45
@imkabir
Copy link
Contributor Author

imkabir commented Sep 23, 2022 •
edited
Loading

@keithc-ca I added this nls message: "J9NLS_DMP_PROCESSING_DETAILED_EVENT_TIME". These are how it looks in different languages:

ca: JVMDUMP055I S'està processant la incidència d'abocament de memòria "throw", detall "java/lang/ClassNotFoundException" "kabir.DontPanic" a 2022/09/22 06:21:05 - espereu.

cs: JVMDUMP055I Probíhá zpracování události výpisu paměti "throw", podrobnosti "java/lang/ClassNotFoundException" "kabir.DontPanic" v 2022/09/22 06:23:00 - čekejte.

de: JVMDUMP055I Speicherauszugsereignis "throw", Detail "java/lang/ClassNotFoundException" "kabir.DontPanic" um 2022/09/22 06:24:43 - bitte warten.

es: JVMDUMP055I Procesando el suceso de volcado "throw", detalles "java/lang/ClassNotFoundException" "kabir.DontPanic" en 2022/09/22 06:26:49 - espere.

fr: JVMDUMP055I Traitement de l'événement de vidage "throw", détails "java/lang/ClassNotFoundException" "kabir.DontPanic" à 2022/09/22 07:06:31 - Veuillez patienter.

hu: JVMDUMP055I "throw" kiíratási esemény feldolgozása, részletek: "java/lang/ClassNotFoundException" "kabir.DontPanic", 2022/09/22 06:31:42 - Kérem várjon.

it: JVMDUMP055I Elaborazione dell'evento dump "throw", dettagli "java/lang/ClassNotFoundException" "kabir.DontPanic" in 2022/09/22 06:32:18 - attendere.

ja: JVMDUMP055I ダンプ・イベント "throw"、詳細 "java/lang/ClassNotFoundException" "kabir.DontPanic" (場所: 2022/09/22 06:33:10) を処理しています - お待ちください。

ko: JVMDUMP055I JVMDUMP055I 덤프 이벤트 "throw" 처리 중, 2022/09/22 07:05:58의 세부사항 "java/lang/ClassNotFoundException" "kabir.DontPanic" - 잠시 기다리십시오.

pl: JVMDUMP055I Przetwarzanie zdarzenia zrzutu "throw", szczegół "java/lang/ClassNotFoundException" "kabir.DontPanic": 2022/09/22 06:35:11 - proszę czekać.

pt_BR: JVMDUMP055I Processando o evento de dump "throw", detalhe "java/lang/ClassNotFoundException" "kabir.DontPanic" em 2022/09/22 06:36:03 - aguarde.

ru: JVMDUMP055I Обработка события дампа "throw", элемент "java/lang/ClassNotFoundException" "kabir.DontPanic" в 2022/09/22 06:36:44. Подождите.

sk: JVMDUMP055I Spracúva sa udalosť výpisu "throw", podrobnosti "java/lang/ClassNotFoundException" "kabir.DontPanic" v 2022/09/22 06:37:25. Čakajte.

sl: JVMDUMP055I Obdelava dogodka izpisa pomnilnika "throw", podrobnost "java/lang/ClassNotFoundException" "kabir.DontPanic" pri 2022/09/22 06:37:59 – prosimo, počakajte.

tr: JVMDUMP055I "throw" döküm olayı (ayrıntı "java/lang/ClassNotFoundException" "kabir.DontPanic") işleniyor - 2022/09/22 06:38:42 - Lütfen bekleyin.

zh_CN: JVMDUMP055I 正在处理转储事件“throw”，详细信息“java/lang/ClassNotFoundException” “kabir.DontPanic”，位于 2022/09/22 06:42:16 - 请稍候。

zh_TW: JVMDUMP055I 正在 2022/09/22 06:42:49 處理傾出事件 "throw"，詳細資料 "java/lang/ClassNotFoundException" "kabir.DontPanic" - 請稍候。

keithc-ca
keithc-ca requested changes Sep 23, 2022
View reviewed changes
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/rasdump/trigger.c Outdated Show resolved Hide resolved
runtime/nls/dump/j9dmp.nls Outdated Show resolved Hide resolved
runtime/nls/dump/j9dmp.nls Outdated Show resolved Hide resolved
@imkabir imkabir requested a review from keithc-ca October 7, 2022 05:51
@imkabir
Add Exception message to Xdump stack agent output
f5c8a5b 
When Xdump:stack is used to dump stack trace filtered on an exception,
this change along with the primary exception message, displays
additional detail about the exception if any. This is similar to how
javacore displays additional detail about an exception in 1TISIGINFO
tag.

Fixes: eclipse-openj9#8435
Signed-off-by: Kabir Islam <kaislam1@in.ibm.com>
@keithc-ca
Copy link
Contributor

jenkins test sanity alinux64 jdk17

@keithc-ca keithc-ca merged commit 2369840 into eclipse-openj9:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Add Exception message to Xdump's "stack" agent output
3 participants
@imkabir @pshipton @keithc-ca